Skip to content

Remove dead code#543

Merged
k8s-ci-robot merged 4 commits intokubernetes-csi:masterfrom
carlory:cleanp-deadcode
Jan 12, 2026
Merged

Remove dead code#543
k8s-ci-robot merged 4 commits intokubernetes-csi:masterfrom
carlory:cleanp-deadcode

Conversation

@carlory
Copy link
Member

@carlory carlory commented Dec 9, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove dead code

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: carlory <baofa.fan@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 9, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2025
@carlory
Copy link
Member Author

carlory commented Dec 10, 2025

/retest

@humblec
Copy link
Contributor

humblec commented Dec 10, 2025

@carlory can you check the failure?

b12e407c Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547 Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9 Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d Add myself as csi approver
c852fa79 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c10 fix: upgrade to go1.24.11 to fix CVE-2025-61727

git-subtree-dir: release-tools
git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb
Signed-off-by: carlory <baofa.fan@daocloud.io>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2025
@carlory
Copy link
Member Author

carlory commented Dec 10, 2025

@humblec After release-tool is rebased, the ci is green.

configvar CSI_PROW_KIND_IMAGES "kindest/node:v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a
kindest/node:v1.33.4@sha256:25a6018e48dfcaee478f4a59af81157a437f15e6e140bf103f85a2e7cd0cbbf2
kindest/node:v1.32.8@sha256:abd489f042d2b644e2d033f5c2d900bc707798d075e8186cb65e3f1367a9d5a1
kindest/node:v1.31.12@sha256:0f5cc49c5e73c0c2bb6e2df56e7df189240d83cf94edfa30946482eb08ec57d2" "kind images"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are removing other node images ? is it based on N-3 support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, humblec, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 14d766a into kubernetes-csi:master Jan 12, 2026
7 checks passed
@carlory carlory deleted the cleanp-deadcode branch January 12, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants