Update dependency go modules for k8s v1.28.0-rc.0#318
Update dependency go modules for k8s v1.28.0-rc.0#318k8s-ci-robot merged 4 commits intokubernetes-csi:masterfrom
Conversation
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
|
Welcome @Sneha-at! |
|
Hi @Sneha-at. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
I think you synced release-tools at the same time as bumping a library, could you please split the PRs? |
|
@mauriciopoppe syncing release-tools and bumping dependencies in the PR is intended according to the script we have. But we can probably separate them into two commits in the same PR. |
mauriciopoppe
left a comment
There was a problem hiding this comment.
I understand and it's already in 2 commits so it's good
/lgtm
/approve
71872ee to
33779e0
Compare
|
There's a few more changes in release tools we should pick up. Can you refresh the release-tools update after kubernetes-csi/csi-release-tools#229 merges? |
|
@msau42 we still need to do the v1.28.0 release as well later, release-tool update will be picked up after this PR? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauriciopoppe, msau42, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran kubernetes-csi/release-tools go-get-kubernetes.sh -p 1.28.0-rc.0