Skip to content

Parse go version from release-tools#392

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:test-trivy
Nov 21, 2025
Merged

Parse go version from release-tools#392
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:test-trivy

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
trivy.yaml should use the same go version as release tools, so it checks for CVEs with the same go as we use to build images.

Add a step that parses the go version from prow.sh and stores it in .go-version file. Use the file in subsequent setup-go step.

This partially reverts #390 and reworks trivy.yaml in a different way.

Does this PR introduce a user-facing change?:

NONE

trivy.yaml should use the same go version as release tools, so it checks
for CVEs with the same go as we use to build images.

Add a step that parses the go version from prow.sh and stores it in
.goversion file. Use the file in subsequent setup-go step.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 21, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2025
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f4596eb into kubernetes-csi:master Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants