Change default probe timeout to 3 seconds#365
Change default probe timeout to 3 seconds#365k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
|
Welcome @sathieu! |
|
Hi @sathieu. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
See issue 293
b6dcf49 to
518789f
Compare
|
Can someone review this PR? @jsafrane, @andyzhangx, others? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane, sathieu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
The default probe timeout looks to low, and is increased in a lot of places as shown here and here. azure-lustre up to 120s!
I proposed to increase it in vsphere-csi-driver.
A better approach is to change the default, i.e. this PR
Which issue(s) this PR fixes:
Fixes #293
Special notes for your reviewer:
Is this a breaking change?
Does this PR introduce a user-facing change?: