Skip to content

Fix for CVE go-2023-1571#815

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
shubhamrajvanshi:CVE-GO-2023-1571
Feb 27, 2023
Merged

Fix for CVE go-2023-1571#815
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
shubhamrajvanshi:CVE-GO-2023-1571

Conversation

@shubhamrajvanshi
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind security

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fixes https://pkg.go.dev/vuln/GO-2023-1571
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This should help merge #811 as mentioned here
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@shubhamrajvanshi: The label(s) kind/security cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?
/kind security

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fixes https://pkg.go.dev/vuln/GO-2023-1571
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This should help merge #811 as mentioned here
Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @shubhamrajvanshi!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @shubhamrajvanshi. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 27, 2023
@shubhamrajvanshi shubhamrajvanshi changed the title CVE go 2023 1571 Fix for CVE go-2023-1571 Feb 27, 2023
@xing-yang
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2023
@xing-yang
Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubhamrajvanshi, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0559478 into kubernetes-csi:master Feb 27, 2023
@xing-yang
Copy link
Copy Markdown
Collaborator

@shubhamrajvanshi can you cherry-pick this PR to release-6.2 branch?

@shubhamrajvanshi
Copy link
Copy Markdown
Contributor Author

I have created the PR but can't add you over there as reviewer #816

@andyzhangx
Copy link
Copy Markdown
Member

/cherrypick release-5.0

1 similar comment
@andyzhangx
Copy link
Copy Markdown
Member

/cherrypick release-5.0

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@andyzhangx: #815 failed to apply on top of branch "release-5.0":

Applying: updated go module files
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 updated go module files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Copy Markdown
Member

andyzhangx commented Mar 16, 2023

@andyzhangx: #815 failed to apply on top of branch "release-5.0":

Applying: updated go module files
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 updated go module files
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@xing-yang this could prove the cherrypick bot works on current repo, I will add cherrypick bot for other csi driver repo.
sometimes it fail because of merge conflict, that's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants