Allow tuning common-controller Ratelimiter with retryIntervalStart & retryIntervalMax#530
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Jun 12, 2021
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/S
humblec
changed the title
retryIntervalStart & retryIntervalMax
humblec
changed the title
retryIntervalStart & retryIntervalMaxretryIntervalStart & retryIntervalMax
Contributor
Author
|
/assign @xing-yang |
xing-yang
reviewed
Jun 11, 2021
… retryIntervalMax` This patch adds two new parameters `retryIntervalStart & retryIntervalMax` which can be configured to adjust the ratelimiters of snapshotqueue and contentqueue in the controller. Signed-off-by: Humble Chirammal <hchiramm@redhat.com> ```release-note `retry-interval-start` and `retry-interval-max` arguments are added to common-controller which controls retry interval of failed volume snapshot creation and deletion. These values set the ratelimiter for snapshot and content queues. ``` Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds two new parameters
retryIntervalStart & retryIntervalMaxwhich can be configured to adjust the ratelimiters of snapshotqueue and contentqueue
in the controller.
Signed-off-by: Humble Chirammal hchiramm@redhat.com