Skip to content

Move snapshot validations to validation-webhook directory#479

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
prateekpandey14:refact-validation
Mar 15, 2021
Merged

Move snapshot validations to validation-webhook directory#479
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
prateekpandey14:refact-validation

Conversation

@prateekpandey14
Copy link
Copy Markdown
Contributor

Signed-off-by: prateekpandey14 prateekpandey14@gmail.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor and move snapshot specific validations to pkg/validation-webhook folder

Which issue(s) this PR fixes:
Fixes #443

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 3, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @prateekpandey14. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2021
@xing-yang
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2021
Comment thread pkg/validation-webhook/validation.go Outdated
@xing-yang
Copy link
Copy Markdown
Collaborator

/retest

Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
@xing-yang
Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prateekpandey14, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 02450fd into kubernetes-csi:master Mar 15, 2021
@prateekpandey14 prateekpandey14 deleted the refact-validation branch March 15, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move webhook logic from utils to validation-webhook folder

3 participants