Cherry pick of #287: Updated sidecar to not require VolumeSnapshotClass for snapshot deletion

[ialidzhikov]

/kind bug

Cherry pick of #287 on release-2.1.

#287: Updated sidecar to not require VolumeSnapshotClass for snapshot deletion

Which issue(s) this PR fixes:

Ref #306

Does this PR introduce a user-facing change?:

Cherry pick of #287: Allows the sidecar to delete volume snapshots if the volume snapshot class is not found.

[k8s-ci-robot]

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ialidzhikov]

/cc @huffmanca @xing-yang

[xing-yang]

/ok-to-test

[ialidzhikov]

/test pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20

[ialidzhikov]

@xing-yang , pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20 fails to clone v1.20.0 of kubernetes/kubernetes. I don’t think that it is something related to this PR.

[ialidzhikov]

/assign @xing-yang

[xing-yang]

/test pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20

[ialidzhikov]

@xing-yang , I believe the job configuration is wrong.

It currently tries to clone 1.20.0 but there is no such tag. It should be v1.20.0.

-git clone --single-branch --branch 1.20.0 https://github.com/kubernetes/kubernetes /tmp/kubernetes
+git clone --single-branch --branch v1.20.0 https://github.com/kubernetes/kubernetes /tmp/kubernetes

Where lives the configuration this job?

[xing-yang]

@pohly any idea why "v" is missing from "v1.20.0" for this backport? It is there for PRs running in master branch.

[xing-yang]

I see a difference between the two:

https://github.com/kubernetes-csi/external-snapshotter/blob/release-2.1/release-tools/prow.sh#L573
https://github.com/kubernetes-csi/external-snapshotter/blob/master/release-tools/prow.sh#L575

https://github.com/kubernetes-csi/external-snapshotter/blob/master/release-tools/prow.sh#L68-L78

[ialidzhikov]

I see a difference between the two:

https://github.com/kubernetes-csi/external-snapshotter/blob/release-2.1/release-tools/prow.sh#L573
https://github.com/kubernetes-csi/external-snapshotter/blob/master/release-tools/prow.sh#L575

https://github.com/kubernetes-csi/external-snapshotter/blob/master/release-tools/prow.sh#L68-L78

See https://github.com/kubernetes-csi/external-snapshotter/pull/464/files -> version_to_git func. I believe somewhere in https://github.com/kubernetes-csi/external-snapshotter/pull/464/files there is a fix for the failing git clone in pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20..

[xing-yang]

I think you can submit a separate PR just to add that version_to_git logic in release-2.1.

CC @pohly @mattcary

[ialidzhikov]

The PR was based on old revision from release-2.1 branch. I rebased it to latest release-2.1 but it failed with the same error. @xing-yang , I have locally a change that can fix the git clone for pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-1-20 . Should I create a PR with it to tackle this issue or? I see that this job/check is not labelled as required.

[xing-yang]

We can't merge a PR that can't pass a CI.

[ialidzhikov]

@xing-yang , I created kubernetes/test-infra#20792 which should address the issue with the K8s 1.20 tests that should not be executed against external-snapshotter@release-2.1.

[pohly]

We can't merge a PR that can't pass a CI.

1-20-on-kubernetes-1-20 is intentionally not required to pass at this time, therefore you can merge PRs even when it is failing.

[vpnachev]

/lgtm

[k8s-ci-robot]

@vpnachev: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, rfranzke, vpnachev, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment