Move snapshot APIs and client to v1 (no controller changes)#419
Move snapshot APIs and client to v1 (no controller changes)#419k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Conversation
|
/assign @msau42 |
|
Hi @yuxiangqian, Here is the PR including only API and clientset changes (same as #389 except that it does not have controller changes). Please take a look. Thanks. |
|
/assign @yuxiangqian |
yuxiangqian
left a comment
There was a problem hiding this comment.
overall lgtm with some nits. It's really hard to review this type of changes :). I'd highly suggest, if there is next time, to only include those files which are not auto-generated in the first PR (even though the build/test might fail) to ease the process.
|
@yuxiangqian addressed your comments. PTAL. |
client/config/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml
Outdated
Show resolved
Hide resolved
|
/assign @saad-ali |
|
/lgtm |
|
@saad-ali addressed your comments. Can you please take another look? Thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saad-ali has given lgtm and approved this PR. Removing the hold. /hold cancel |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This PR moves snapshot APIs and client to v1. This only includes API and client changes.
Controller changes are in a separate PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: