Skip to content

Move snapshot APIs and client to v1 (no controller changes)#419

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
xing-yang:only_api
Nov 11, 2020
Merged

Move snapshot APIs and client to v1 (no controller changes)#419
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
xing-yang:only_api

Conversation

@xing-yang
Copy link
Collaborator

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR moves snapshot APIs and client to v1. This only includes API and client changes.
Controller changes are in a separate PR.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Move Snapshot APIs to V1.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2020
@xing-yang
Copy link
Collaborator Author

/assign @msau42

@xing-yang
Copy link
Collaborator Author

Hi @yuxiangqian,
Michelle suggested that I submit one PR including only API and clientset changes so we can pass CI. After that submit another PR with controller changes.

Here is the PR including only API and clientset changes (same as #389 except that it does not have controller changes). Please take a look. Thanks.

@xing-yang
Copy link
Collaborator Author

/assign @yuxiangqian

Copy link
Contributor

@yuxiangqian yuxiangqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm with some nits. It's really hard to review this type of changes :). I'd highly suggest, if there is next time, to only include those files which are not auto-generated in the first PR (even though the build/test might fail) to ease the process.

@xing-yang
Copy link
Collaborator Author

@yuxiangqian addressed your comments. PTAL.

@xing-yang
Copy link
Collaborator Author

/assign @saad-ali

@yuxiangqian
Copy link
Contributor

/lgtm
/hold
for @saad-ali

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@xing-yang
Copy link
Collaborator Author

@saad-ali addressed your comments. Can you please take another look? Thanks.

Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xing-yang
Copy link
Collaborator Author

@saad-ali has given lgtm and approved this PR. Removing the hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 606d304 into kubernetes-csi:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants