add instructions on creating volume snapshot quota for CRs#410
add instructions on creating volume snapshot quota for CRs#410k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
kind/documentation
|
Hi @boddumanohar. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/S
| spec: | ||
| hard: | ||
| count/volumesnapshots.snapshot.storage.k8s.io: "10" | ||
| count/volumesnapshotclasses.snapshot.storage.k8s.io: "10" |
There was a problem hiding this comment.
VolumeSnapshotClass is non-namespaced objects. Isn't resource quota only for namespaced objects?
|
|
||
| ### Setting Quota limits with Snapshot custom resources | ||
| [`ResourceQuotas`](https://kubernetes.io/docs/concepts/policy/resource-quotas/) are namespaced objects that can be used to set limits on objects of a particular [`Group.Version.Kind`](https://book.kubebuilder.io/cronjob-tutorial/gvks.html). Before we set resource quota, make sure that snapshot CRDs are installed in the cluster. If not please follow [this guide](https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/docs/deploy-1.17-and-later.md) | ||
| ``` |
There was a problem hiding this comment.
I'd just reference the Usage section of README as deploy-1.17-and-later.md will need an update as well.
There was a problem hiding this comment.
that makes sense. updated.
There was a problem hiding this comment.
Add a period at the end of the sentence.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
|
||
| ### Setting Quota limits with Snapshot custom resources | ||
| [`ResourceQuotas`](https://kubernetes.io/docs/concepts/policy/resource-quotas/) are namespaced objects that can be used to set limits on objects of a particular [`Group.Version.Kind`](https://book.kubebuilder.io/cronjob-tutorial/gvks.html). Before we set resource quota, make sure that snapshot CRDs are installed in the cluster. If not please follow [this guide](https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/docs/deploy-1.17-and-later.md) | ||
| ``` |
There was a problem hiding this comment.
Add a period at the end of the sentence.
| count/volumesnapshots.snapshot.storage.k8s.io: "10" | ||
| ``` | ||
|
|
||
| if you try to create more snapshots than what is allowed, you will see error like: |
There was a problem hiding this comment.
if -> If
you will see error like: -> you will see an error like the following:
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: boddumanohar, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds instructions on setting up resource quotas for VolumeSnapshot CRS
Which issue(s) this PR fixes:
Fixes #382
Special notes for your reviewer:
Does this PR introduce a user-facing change?: