Skip to content

cherry-pick #293: revamp find content logic to fix 290 291 292#303

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:release-2.1from
yuxiangqian:cherrypick-2.1
Apr 24, 2020
Merged

cherry-pick #293: revamp find content logic to fix 290 291 292#303
k8s-ci-robot merged 1 commit intokubernetes-csi:release-2.1from
yuxiangqian:cherrypick-2.1

Conversation

@yuxiangqian
Copy link
Copy Markdown
Contributor

@yuxiangqian yuxiangqian commented Apr 24, 2020 •
edited
Loading

(cherry picked from commit 45324b7)

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #293

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cherry-pick from #293 

This PR fixes the following issues in snapshot controller in release branch 2.1:
Issue #290 : Disallow a pre-provisioned VolumeSnapshot pointing to a dynamically created VolumeSnapshotContent
Issue #291 : Verify VolumeSnapshot and VolumeSnapshotContent are bi-directional bound before initializing a deletion on a VolumeSnapshotContent which the to-be-deleted VolumeSnapshot points to.
Issue #292 : Allow deletion of a VolumeSnapshot/VolumeSnapshotContent when the VolumeSnapshotContent's DeletionPolicy

@yuxiangqian
revamp find content logic to fix 290 291 292
f1f0c90 
add snapshot source validation in syncSnapshot
add content source validation in syncContent

(cherry picked from commit 45324b7)
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2020
@yuxiangqian
Copy link
Copy Markdown
Contributor Author

yuxiangqian commented Apr 24, 2020

/assign @xing-yang

@xing-yang
Copy link
Copy Markdown
Collaborator

xing-yang commented Apr 24, 2020

@yuxiangqian can you add a line in the release note stating that this is a cherry pick and referencing the original PR number?

@yuxiangqian
Copy link
Copy Markdown
Contributor Author

yuxiangqian commented Apr 24, 2020

@yuxiangqian can you add a line in the release note stating that this is a cherry pick and referencing the original PR number?
done

@xing-yang
Copy link
Copy Markdown
Collaborator

xing-yang commented Apr 24, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, yuxiangqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [xing-yang,yuxiangqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e5239c4 into kubernetes-csi:release-2.1 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuxiangqian @xing-yang @k8s-ci-robot