Remove unwanted code conditions #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
size/L
Contributor
Author
|
/kind cleanup |
k8s-ci-robot
added
release-note-none
Contributor
|
thanks @humblec , could you rebase? |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
size/M
Contributor
Author
@yuxiangqian @xing-yang done.. ptal. 👍 |
Contributor
Author
|
/retest |
Signed-off-by: Humble Chirammal <[email protected]>
k8s-ci-robot
added
size/L
Collaborator
|
@humblec do you still want to hold this? |
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
@xing-yang no.. this is good to go !! Thanks! |
Collaborator
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: