Add more sidecar tests and cleanup sidecar code #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
snapshot_controller.go at 81.8% coverage now, was 61.3% |
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
add_more_sidecar_ctrl_tests
branch
from
6f02362 to
fe1c355
Compare
ggriffiths
commented
Mar 5, 2020
| ctrl.updateContentErrorStatusWithEvent(content, v1.EventTypeWarning, "SnapshotCreationFailed", fmt.Sprintf("Failed to create snapshot with error %v", err)) | ||
| return err | ||
| } | ||
| ctrl.createSnapshot(content) |
There was a problem hiding this comment.
These functions will never return an error because they just schedule async operations. Each async operation creates an event upon any failures. Deletion seems to be implemented similarly (see above L66 and 72), except it always just passes the nil error further up the stack.
|
The issue #191 you referenced is not an issue. It was a PR from you that was merged. Do you want to open another issue to track this? |
|
I opened a new issue to track this. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rhrmo
added a commit
to rhrmo/external-snapshotter
that referenced
this pull request
Dec 17, 2024
04965932 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1f Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d Update cloudbuild image with go 1.21+ 406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273d Set GOMODCACHE to avoid re-download toolchain 98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff6 Remove --kube-root deprecated kind argument 734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch 43bde065 Bump csi-sanity to 5.3.1 f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966f Treat main branch as equivalent to master branch 6b05f0fc use new GOTOOLCHAIN env to manage go version 18b6ac6d chore: update CSI driver version to 1.15 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
Merged
AndrewSirenko
added a commit
to AndrewSirenko/external-snapshotter
that referenced
this pull request
Dec 17, 2024
049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 43bde065f Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
AndrewSirenko
added a commit
to AndrewSirenko/external-snapshotter
that referenced
this pull request
Feb 26, 2025
90efb2ca5 Merge pull request kubernetes-csi#272 from andyzhangx/patch-3 9b616fec4 Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866 049659326 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1ff Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d9 Update cloudbuild image with go 1.21+ 406a79acf Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273d8 Set GOMODCACHE to avoid re-download toolchain 98f23071d Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712d0 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff66 Remove --kube-root deprecated kind argument 734c2b950 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch 43bde065f Bump csi-sanity to 5.3.1 f95c855be Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966fe Treat main branch as equivalent to master branch 6b05f0fcc use new GOTOOLCHAIN env to manage go version 18b6ac6d2 chore: update CSI driver version to 1.15 git-subtree-dir: release-tools git-subtree-split: 90efb2ca59900f19eba05e65da28beda79c5bb28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #267
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: