Skip to content

Cherry-pick: Verify PV/PVC binding and driver#173

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:release-1.2from
xing-yang:release-1.2
Oct 9, 2019
Merged

Cherry-pick: Verify PV/PVC binding and driver#173
k8s-ci-robot merged 1 commit intokubernetes-csi:release-1.2from
xing-yang:release-1.2

Conversation

@xing-yang
Copy link
Copy Markdown
Collaborator

Backport PV/PVC binding change (#172) to release-1.2 branch.

Note: Resolved merge conflicts in pkg/controller/snapshot_create_test.go.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixed checking of binding of PVC when creating snapshots.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added extra verification of source PersistentVolumeClaim before creating snapshot.

Note: Resolved merge conflicts in
pkg/controller/snapshot_create_test.go.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 9, 2019

/test pull-kubernetes-csi-external-snapshotter-alpha-1-15-on-kubernetes-1-15
/test pull-kubernetes-csi-external-snapshotter-alpha-1-14-on-kubernetes-1-14

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 9, 2019

/assign

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 70c34a2 into kubernetes-csi:release-1.2 Oct 9, 2019
andyzhangx pushed a commit to andyzhangx/external-snapshotter that referenced this pull request Jun 5, 2024
Added WS2022 to 'CSI_PROW_BUILD_PLATFORMS'
jsafrane pushed a commit to jsafrane/external-snapshotter that referenced this pull request May 30, 2025
…ncy-openshift-4.18-csi-snapshot-validation-webhook

OCPBUGS-48723: Updating ose-csi-snapshot-validation-webhook-container image to be consistent with ART for 4.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants