-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CEL rules test suite #1079
Add CEL rules test suite #1079
Conversation
Hi @leonardoce. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I'm not 100% sure which directory to add these test cases to. Any feedback is greatly appreciated. |
/ok-to-test |
client/hack/README.md
Outdated
### Prerequisites | ||
|
||
- Kubectl access to a cluster with the installed CRDs | ||
- Kubernetes >= 1.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've bumped the K8s deps to 1.30. Can you change to >=1.30?
This patch adds several YAML test cases that check if the CEL rules included in the CRDs are correctly working. Both validation rules and transition rules are checked. A shell script is provided to execute these tests.
Signed-off-by: Leonardo Cecchi <[email protected]>
7a5b9d7
to
5f75129
Compare
I rebased it and tested it against the new |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
This patch adds several YAML test cases that check if the CEL rules included in the CRDs are correctly working. Both validation rules and transition rules are checked.
A shell script is provided to execute these tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: