Skip to content

Sync Release tools repo subtree #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

Sync Release tools repo subtree #83

merged 2 commits into from
Dec 12, 2024

Conversation

Rakshith-R
Copy link
Contributor

@Rakshith-R Rakshith-R commented Dec 5, 2024 •
edited
Loading

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This pr syncs release-tools folder with csi-release-tools repository.

Which issue(s) this PR fixes:
Resolves #74

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Rakshith-R. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@Rakshith-R
Copy link
Contributor Author

/cc @PrasadG193 @carlbraganza

@hairyhum
Copy link
Contributor

hairyhum commented Dec 6, 2024

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@Rakshith-R
Copy link
Contributor Author

/approve

I guess this pr needs /lgtm too

PrasadG193
PrasadG193 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@Rakshith-R
Copy link
Contributor Author

/test pull-kubernetes-csi-external-snapshot-metadata-unit

@k8s-ci-robot
Copy link
Contributor

@Rakshith-R: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-csi-external-snapshot-metadata-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rakshith-R
Copy link
Contributor Author

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_external-snapshot-metadata/83/pull-kubernetes-csi-external-snapshot-metadata-unit/1866079543341617152

maybe a flaky test ?

@PrasadG193
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2024
@Rakshith-R
Copy link
Contributor Author

/test pull-kubernetes-csi-external-snapshot-metadata-1-29-on-kubernetes-1-29

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@Rakshith-R
Copy link
Contributor Author

kubernetes-csi/csi-release-tools#262 (comment)

k8s 1.29 test failure is occuring in all sidecar repos

@Rakshith-R
Squashed 'release-tools/' changes from 988496a..406a79a
ffd782b 
406a79a Merge pull request #267 from huww98/gomodcache
9cec273 Set GOMODCACHE to avoid re-download toolchain
98f2307 Merge pull request #260 from TerryHowe/update-csi-driver-version
e9d8712 Merge pull request #259 from stmcginnis/deprecated-kind-kube-root
faf79ff Remove --kube-root deprecated kind argument
734c2b9 Merge pull request #265 from Rakshith-R/consider-main-branch
f95c855 Merge pull request #262 from huww98/golang-toolchain
3c8d966 Treat main branch as equivalent to master branch
e31de52 Merge pull request #261 from huww98/golang
fd153a9 Bump golang to 1.23.1
a8b3d05 pull-test.sh: fix "git subtree pull" errors
6b05f0f use new GOTOOLCHAIN env to manage go version
18b6ac6 chore: update CSI driver version to 1.15
227577e Merge pull request #258 from gnufied/enable-race-detection
e1ceee2 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
@Rakshith-R
Merge commit 'ffd782ba075c63add8b35df831d6b43087efa1b3' into release-…
21590a9 
…tools
@Rakshith-R
Copy link
Contributor Author

/cc @hairyhum

PrasadG193
PrasadG193 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hairyhum, PrasadG193, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6bcdc61 into kubernetes-csi:main Dec 12, 2024
6 checks passed
This was referenced Dec 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@carlory carlory Awaiting requested review from carlory

@xing-yang xing-yang Awaiting requested review from xing-yang

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

@hairyhum hairyhum Awaiting requested review from hairyhum

Assignees

@PrasadG193 PrasadG193

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

prow image build jobs are failing

4 participants

@Rakshith-R @k8s-ci-robot @hairyhum @PrasadG193