fix: use pv annotation to trigger filesystem resize when necessary by sunpa93 · Pull Request #140 · kubernetes-csi/external-resizer

sunpa93 · 2021-02-23T00:15:45Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: add annotation to pv after resize if filesystem resize is necessary. delete when pvc.status.capacity >= pv.spec.capacity

Which issue(s) this PR fixes:

Fixes kubernetes/kubernetes#88683

Special notes for your reviewer:
This PR is a sister PR of kubernetes/kubernetes#99326

Does this PR introduce a user-facing change?:

Add a feature-gate to allow users to restore size of deleted PVCs

k8s-ci-robot · 2021-02-23T00:15:52Z

Welcome @sunpa93!

It looks like this is your first PR to kubernetes-csi/external-resizer 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-resizer has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-02-23T00:15:53Z

Hi @sunpa93. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2021-02-23T19:57:58Z

/ok-to-test

gnufied · 2021-02-23T19:58:10Z

/assign

gnufied

Looks good mostly. But I think we need unit tests for some these new behaviours.

pkg/controller/controller.go

sunpa93 · 2021-02-25T02:17:33Z

Looks good mostly. But I think we need unit tests for some these new behaviours.

I have modified the tests so that they check if annotations get properly populated and deleted

gnufied · 2021-03-22T17:05:04Z

/lgtm

gnufied · 2021-04-07T17:10:01Z

/assign @msau42

msau42 · 2021-04-14T05:08:27Z

pkg/controller/controller.go

 	}

+	if ctrl.isNodeExpandComplete(pvc, pv) && metav1.HasAnnotation(pv.ObjectMeta, util.AnnPreResizeCapacity) {
+		if err := ctrl.deletePreResizeCapAnnotation(pv); err != nil {


how come resize controller is deleting the annotation? Shouldn't kubelet do it after nodeexpand is complete?

This is because kubelet does not have the permission to modify PV objects.

@gnufied is this an issue? Does this mean plugins that don't support controller resize and don't run the resizer will get this fix?

Currently I think external-resizer is required even for plugins that don't support controller expansion, because in that case external-resizer calls a NO-OP control-plane expansion and successfully expands the PV. There is no way to update PV spec from kubelet otherwise. So every plugin that supports expansion needs to run resizer.

bc0504a Merge pull request kubernetes-csi#140 from jsafrane/remove-unused-k8s-libs 5b1de1a go-get-kubernetes.sh: remove unused k8s libs 49b4269 Merge pull request kubernetes-csi#120 from pohly/add-kubernetes-release f7e7ee4 docs: steps for adding testing against new Kubernetes release git-subtree-dir: release-tools git-subtree-split: bc0504ad76ac6e20d0d7c60d46f62c7ff7591f8c

cmd/csi-resizer/main.go

necessary. delete when pvc.status.capacity >= pv.spec.capacity

Jiawei0227 · 2021-04-29T18:07:29Z

Any updates on this? We are pending on csi-resizer release

pkg/controller/controller.go

gnufied · 2021-04-30T15:02:43Z

Can you squash 4 last commits in one?

sunpa93 · 2021-04-30T16:35:50Z

Can you squash 4 last commits in one?

Done :)

gnufied · 2021-04-30T17:11:01Z

/lgtm

gnufied · 2021-05-04T02:07:45Z

/approve

k8s-ci-robot · 2021-05-04T02:07:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ncy-openshift-4.14-ose-csi-external-resizer Updating ose-csi-external-resizer images to be consistent with ART

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2021

k8s-ci-robot requested review from gnufied and mlmhl February 23, 2021 00:15

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2021

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2021

sunpa93 mentioned this pull request Feb 23, 2021

fix: use pv annotation to trigger filesystem resize when necessary kubernetes/kubernetes#99326

Merged

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021

k8s-ci-robot assigned gnufied Feb 23, 2021

sunpa93 force-pushed the fs_resize_fix branch from 024a4c3 to ea04a85 Compare February 24, 2021 00:16

gnufied reviewed Feb 24, 2021

View reviewed changes

pkg/controller/controller.go Outdated Show resolved Hide resolved

pkg/controller/controller.go Outdated Show resolved Hide resolved

pkg/controller/controller.go Outdated Show resolved Hide resolved

pkg/controller/controller.go Outdated Show resolved Hide resolved

sunpa93 force-pushed the fs_resize_fix branch from ea04a85 to 0a14f02 Compare February 25, 2021 02:15

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2021

sunpa93 force-pushed the fs_resize_fix branch from 0a14f02 to a806f83 Compare March 9, 2021 07:57

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021

k8s-ci-robot assigned msau42 Apr 7, 2021

msau42 reviewed Apr 14, 2021

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021

gnufied reviewed Apr 26, 2021

View reviewed changes

cmd/csi-resizer/main.go Show resolved Hide resolved

k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 27, 2021

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 27, 2021

sunpa93 force-pushed the fs_resize_fix branch from a4e68a7 to 59ff70b Compare April 27, 2021 19:48

sunpa93 added 3 commits April 27, 2021 22:07

fix: add annotation to pv after resize if filesystem resize is

f238af5

necessary. delete when pvc.status.capacity >= pv.spec.capacity

allow toggling of use of PV annotation to mark its pre-resize capacity

5e31bd3

use feature gate for toggling FsResizeAnnotation feature on/off

88ca032

sunpa93 force-pushed the fs_resize_fix branch from a770307 to 9b503b8 Compare April 27, 2021 22:20

gnufied reviewed Apr 30, 2021

View reviewed changes

pkg/controller/controller.go Outdated Show resolved Hide resolved

rebase and vendor update

ff1a210

sunpa93 force-pushed the fs_resize_fix branch from 892e201 to ff1a210 Compare April 30, 2021 16:35

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021

k8s-ci-robot merged commit afddeb2 into kubernetes-csi:master May 4, 2021

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 5, 2021

dobsonj pushed a commit to dobsonj/external-resizer that referenced this pull request Oct 16, 2023

Merge pull request kubernetes-csi#140 from openshift-bot/art-consiste…

ee117b6

…ncy-openshift-4.14-ose-csi-external-resizer Updating ose-csi-external-resizer images to be consistent with ART

Conversation

sunpa93 commented Feb 23, 2021 • edited by gnufied Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 23, 2021

Uh oh!

k8s-ci-robot commented Feb 23, 2021

Uh oh!

gnufied commented Feb 23, 2021

Uh oh!

gnufied commented Feb 23, 2021

Uh oh!

gnufied left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunpa93 commented Feb 25, 2021

Uh oh!

gnufied commented Mar 22, 2021

Uh oh!

gnufied commented Apr 7, 2021

Uh oh!

msau42 Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

sunpa93 Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

msau42 Apr 27, 2021

Choose a reason for hiding this comment

Uh oh!

gnufied Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jiawei0227 commented Apr 29, 2021

Uh oh!

Uh oh!

gnufied commented Apr 30, 2021

Uh oh!

sunpa93 commented Apr 30, 2021

Uh oh!

gnufied commented Apr 30, 2021

Uh oh!

gnufied commented May 4, 2021

Uh oh!

k8s-ci-robot commented May 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sunpa93 commented Feb 23, 2021 •

edited by gnufied

Loading