Skip to content

Bump kube dependencies to v1.19.0 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Aug 29, 2020
Merged

Bump kube dependencies to v1.19.0 #101

k8s-ci-robot merged 1 commit into from
Aug 29, 2020

Conversation

@humblec
Copy link
Contributor

@humblec humblec commented Aug 27, 2020

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@humblec
Bump kube dependencies to v1.19.0
fb25c84 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from mlmhl and msau42 August 27, 2020 03:41
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2020
@humblec
Copy link
Contributor Author

humblec commented Aug 27, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2020
@humblec
Copy link
Contributor Author

humblec commented Aug 27, 2020

/assign @gnufied

@humblec
Copy link
Contributor Author

humblec commented Aug 27, 2020

/test pull-kubernetes-csi-external-resizer-unit

gnufied
gnufied reviewed Aug 27, 2020
View reviewed changes
go.mod
require (
github.com/container-storage-interface/spec v1.2.0
github.com/container-storage-interface/spec v1.3.0
github.com/imdario/mergo v0.3.9 // indirect
Copy link
Contributor

@gnufied gnufied Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to update CSI spec or did the update come via k8s client update?

Copy link
Contributor Author

@humblec humblec Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied I deliberately updated it , but forgot to explictly mention it

Copy link
Contributor

@gnufied gnufied Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not update that in this PR.

Copy link
Contributor

@gnufied gnufied Aug 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humblec I see no reason to update CSI spec at last minute within resizer repo. Also have we updated other sidecar's CSI spec version? k8s repo at least is still using 1.2.0.

Copy link
Contributor Author

@humblec humblec Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied I can revert the change too.. please let me know the choice

Copy link
Contributor Author

@humblec humblec Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied better I reverted.. We will update the SPEC 1.3 accordingly. PTAL

@humblec humblec changed the title Bump kube dependencies to v1.19.0 Bump kube dependencies to v1.19.0 and CSI spec to 1.3.0 Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 29, 2020
@humblec humblec changed the title Bump kube dependencies to v1.19.0 and CSI spec to 1.3.0 Bump kube dependencies to v1.19.0 and CSI spec to 1.2.0 Aug 29, 2020
@humblec humblec changed the title Bump kube dependencies to v1.19.0 and CSI spec to 1.2.0 Bump kube dependencies to v1.19.0 . Aug 29, 2020
@humblec humblec changed the title Bump kube dependencies to v1.19.0 . Bump kube dependencies to v1.19.0 Aug 29, 2020
@gnufied
Copy link
Contributor

gnufied commented Aug 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2f907fe into kubernetes-csi:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied gnufied left review comments

@mlmhl mlmhl Awaiting requested review from mlmhl

@msau42 msau42 Awaiting requested review from msau42

Assignees

@gnufied gnufied

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@humblec @gnufied @k8s-ci-robot