Skip to content

WIP: Update snapshot v1 dependency#522

Closed
xing-yang wants to merge 1 commit intokubernetes-csi:masterfrom
xing-yang:update_snapshot_v1
Closed

WIP: Update snapshot v1 dependency#522
xing-yang wants to merge 1 commit intokubernetes-csi:masterfrom
xing-yang:update_snapshot_v1

Conversation

@xing-yang
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates snapshot dependency to v1.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Depends on this PR: kubernetes-csi/external-snapshotter#389
Right now apis and clientset under external-provisioner/vendor/github.com/kubernetes-csi/external-snapshotter/client/v3 are manually copied as it is not released yet.

Does this PR introduce a user-facing change?:

Updates snapshot dependency to v1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2020
@xing-yang xing-yang force-pushed the update_snapshot_v1 branch 3 times, most recently from 95dec5b to cad1962 Compare November 17, 2020 04:23
@xing-yang
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-1-17

@xing-yang
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-18-on-kubernetes-1-18

@xing-yang
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-1-19

@xing-yang
Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-1-17

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@xing-yang: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-provisioner-1-18-on-kubernetes-1-18 2b93551 link /test pull-kubernetes-csi-external-provisioner-1-18-on-kubernetes-1-18
pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-1-19 2b93551 link /test pull-kubernetes-csi-external-provisioner-1-19-on-kubernetes-1-19
pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-1-17 2b93551 link /test pull-kubernetes-csi-external-provisioner-1-17-on-kubernetes-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang xing-yang closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants