Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace "dep" with "go mod" #369

Merged
merged 1 commit into from
Oct 16, 2019
Merged

replace "dep" with "go mod" #369

merged 1 commit into from
Oct 16, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Oct 15, 2019 

Migrated to Go modules, so the source builds also outside of GOPATH.

@pohly
replace "dep" with "go mod", update to Kubernetes 1.15.4
2017577 
A simple "go mod init && go mod tidy" picked incompatible revisions of
the k/k modules, so go-get-kubernetes.sh had to be used which in turn
implied that Kubernetes had to be updated, because a release with
go.mod file is needed by that script. It makes sense to update anyway.

However, there's one exception: the "replace" for
k8s.io/csi-translation-lib had to be removed manually and then a
compatible revision of it was picked with "go get
k8s.io/csi-translation-lib@17db17aaadeb70b1d7259c18ff045f51a1164d39"
(same as in external-attacher).

The external-provisioner code would have to be modified to work with
the newer lib.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 15, 2019
@msau42
Copy link
Collaborator

msau42 commented Oct 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 84eb762 into kubernetes-csi:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @msau42 @k8s-ci-robot