Skip to content

Fix typo for leader-election-type#349

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
leakingtapan:typo
Oct 1, 2019
Merged

Fix typo for leader-election-type#349
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
leakingtapan:typo

Conversation

@leakingtapan
Copy link
Copy Markdown

@leakingtapan leakingtapan commented Sep 28, 2019 •
edited
Loading

What type of PR is this?
/kind bug

Fix typo for leader-election-type

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 28, 2019

@leakingtapan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2019
@leakingtapan
Copy link
Copy Markdown
Author

leakingtapan commented Sep 28, 2019

/cc @davidz627

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 28, 2019
@davidz627
Copy link
Copy Markdown
Contributor

davidz627 commented Sep 30, 2019

I don't think this is a typo really but the fix does make it more consistent.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 1, 2019

/approve
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 272f2c1 into kubernetes-csi:master Oct 1, 2019
@leakingtapan leakingtapan deleted the typo branch October 9, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@davidz627 davidz627

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leakingtapan @k8s-ci-robot @davidz627 @msau42