Skip to content

Record the error if we fail to get referenced storageclass and secret.#348

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
humblec:error-it
Oct 3, 2019
Merged

Record the error if we fail to get referenced storageclass and secret.#348
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
humblec:error-it

Conversation

@humblec
Copy link
Copy Markdown
Contributor

@humblec humblec commented Sep 24, 2019

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 24, 2019

@humblec: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2019
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Sep 24, 2019

/kind cleanup
/release-note-none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 24, 2019
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Sep 24, 2019

/assign @jsafrane @msau42

Madhu-1
Madhu-1 reviewed Sep 24, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2019
msau42
msau42 reviewed Oct 1, 2019
View reviewed changes
@humblec humblec force-pushed the error-it branch 3 times, most recently from c59ecfb to 8b546d4 Compare October 1, 2019 05:46
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Oct 1, 2019

@msau42 PTAL.

msau42
msau42 reviewed Oct 2, 2019
View reviewed changes
pkg/controller/controller.go Outdated
},
})
if err != nil {
klog.Errorf("failed to get secretreference for volume %s: %s", volume.Name, err.Error())
Copy link
Copy Markdown
Collaborator

@msau42 msau42 Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean instead of logging the error and then returning the error (which will get logged again), we should just return an error with this extra msg.

Copy link
Copy Markdown
Contributor

@Madhu-1 Madhu-1 Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I went through the code, we are not logging and return an error. sorry for the suggestion to add logging here

@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Oct 2, 2019

@msau42 PTAL . hopefully the comments are addressed.

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 2, 2019

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 2, 2019

/retest

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 2, 2019

travis is stuck for some reason, you may need to force push to retrigger it

@humblec
Record the error if we fail to get referenced storageclass and secret.
c261016 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Oct 3, 2019

travis is stuck for some reason, you may need to force push to retrigger it

Sure, repushed.. @msau42

@humblec
Copy link
Copy Markdown
Contributor Author

humblec commented Oct 3, 2019

@msau42 can you please bring back lgtm and approval ? Thanks in advance.

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Oct 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit b7bc17b into kubernetes-csi:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@sbezverk sbezverk Awaiting requested review from sbezverk

+1 more reviewer

@Madhu-1 Madhu-1 Madhu-1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@humblec @k8s-ci-robot @msau42 @Madhu-1 @jsafrane