Skip to content

Remove dummy service from the deployment#290

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Madhu-1:remove-svc
Jun 11, 2019
Merged

Remove dummy service from the deployment#290
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Madhu-1:remove-svc

Conversation

@Madhu-1
Copy link
Contributor

@Madhu-1 Madhu-1 commented Jun 10, 2019

csi-provisioner service creation was necessary to run external-provisioner
as statefulset, after moving from statefulset to deployment, we no longer need dummy service.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Madhu-1
Remove dummy service from the deployment
1ed8f4e 
csi-provisioner service creation was
necessary to run external-provisioner
as statefulset, after moving from statefulset
to deployment we no longer need dummy service.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 10, 2019

@Madhu-1: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 10, 2019
@k8s-ci-robot k8s-ci-robot requested review from lpabon and msau42 June 10, 2019 04:40
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 10, 2019

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2019
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jun 10, 2019

/assign @pohly
/assign @jsafrane
/assign @msau42

@msau42
Copy link
Collaborator

msau42 commented Jun 11, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@msau42
Copy link
Collaborator

msau42 commented Jun 11, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7e0f7ab into kubernetes-csi:master Jun 11, 2019
dfajmon added a commit to dfajmon/csi-external-provisioner that referenced this pull request Jan 12, 2026
@dfajmon
Squashed 'release-tools/' changes from b12e407cc..d6846630b
515ee9f 
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5

git-subtree-dir: release-tools
git-subtree-split: d6846630bd10e563861ab5fa870f9b815daf1f61
dfajmon added a commit to dfajmon/csi-external-provisioner that referenced this pull request Jan 13, 2026
@dfajmon
Squashed 'release-tools/' changes from b12e407cc..707a99eca
e1e7e06 
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5

git-subtree-dir: release-tools
git-subtree-split: 707a99ecae026a8faa36d60aa9ea88505b5865df
jsafrane added a commit to jsafrane/external-provisioner that referenced this pull request Feb 6, 2026
@jsafrane
Squashed 'release-tools/' changes from b12e407cc..1e81e752e
c212bf8 
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5

git-subtree-dir: release-tools
git-subtree-split: 1e81e752e87e027311be882279eac9e292705aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@msau42 msau42 Awaiting requested review from msau42

Assignees

@pohly pohly

@jsafrane jsafrane

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Madhu-1 @k8s-ci-robot @msau42 @pohly @jsafrane