[release-1.0] Add secret support for Provision and Delete from pvc name and namespace

[oleksiys]

Backport #274 to Kubernetes 1.13

What type of PR is this?
/kind feature

What this PR does / why we need it:

• This allows Provision to pass the correct PVC object so that the k8s secrets can be pulled and used during provisioning.
• We need this fix in Kubernetes 1.13

Which issue(s) this PR fixes:

• Fixes Need pvc namespace passed to CSI driver #170
• Fixes Allow PVC name/namespace as template for provisioner-secret #233

Does this PR introduce a user-facing change?:

Users can now provide a secret name and namespace during provision by passing the correct storage class parameters: "provisioner-secret-name" and "provisioner-secret-namespace"

[k8s-ci-robot]

Welcome @oleksiys!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @oleksiys. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shay-berman]

@oleksiys is there any documentation that need to be updated as part of this PR? Like what is the user impact here.

[oleksiys]

@shay-berman well in general external provisioner part of this document [1] must be updated. But I'd say it's more related to the original fix #274 than this specific backport.

[1] https://kubernetes-csi.github.io/docs/secrets-and-credentials.html#createdelete-volume-secret

[saad-ali]

/lgtm
/approve

Should this also be cherry picked to release-1.1 in addition to release-1.0 branch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oleksiys, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oleksiys]

/retest

[k8s-ci-robot]

@oleksiys: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saad-ali]

/ok-to-test

[saad-ali]

/test pull-kubernetes-csi-external-provisioner-unit

[k8s-ci-robot]

@oleksiys: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-csi-external-provisioner-unit	9ebbc51	link	/test pull-kubernetes-csi-external-provisioner-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[oleksiys]

@saad-ali AFAICT it's not related to the PR itself:

Activated service account credentials for: [[email protected]]
+ ./.prow.sh
/usr/local/bin/runner.sh: line 117: ./.prow.sh: No such file or directory
+ EXIT_VALUE=127

Is it an infrastructure problem or am I missing something?

[msau42]

cc @pohly
I believe we didn't add the prow tests until 1.1. Do we need to exclude these jobs from older branches?

[pohly]

I believe we didn't add the prow tests until 1.1. Do we need to exclude these jobs from older branches?

Yes. This was already done for most of the jobs, but due to an oversight was missing from the "unit" test job.

Fix is in kubernetes/test-infra#12866

[oleksiys]

Thank you!

/retest