Use leader election library from csi-lib-utils #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
/hold Waiting for kubernetes-csi/csi-lib-utils#24 |
k8s-ci-robot
added
the
do-not-merge/hold
|
How does this affect RBAC rules? |
andrewsykim
force-pushed
the
leader-election
branch
from
8e86a44
to
95e7d7e
Compare
k8s-ci-robot
added
size/L
andrewsykim
force-pushed
the
leader-election
branch
from
95e7d7e
to
92de551
Compare
msau42
reviewed
Apr 3, 2019
| retryIntervalStart = flag.Duration("retry-interval-start", time.Second, "Initial retry interval of failed provisioning or deletion. It doubles with each failure, up to retry-interval-max.") | ||
| retryIntervalMax = flag.Duration("retry-interval-max", 5*time.Minute, "Maximum retry interval of failed provisioning or deletion.") | ||
| workerThreads = flag.Uint("worker-threads", 100, "Number of provisioner worker threads, in other words nr. of simultaneous CSI calls.") | ||
| operationTimeout = flag.Duration("timeout", 10*time.Second, "Timeout for waiting for creation or deletion of a volume") | ||
| _ = deprecatedflags.Add("provisioner") | ||
|
|
||
| enableLeaderElection = flag.Bool("enable-leader-election", false, "Enables leader election. If leader election is enabled, additional RBAC rules are required. Please refer to the Kubernetes CSI documentation for instructions on setting up these RBAC rules.") |
There was a problem hiding this comment.
Add deprecation notice here
There was a problem hiding this comment.
Did you mean for leaderElectionType?
|
|
||
| var le leaderElection | ||
| if *leaderElectionType == "endpoints" { | ||
| le = leaderelection.NewLeaderElectionWithEndpoints(clientset, lockName, run) |
There was a problem hiding this comment.
And deprecation log message here
| @@ -79,6 +79,9 @@ rules: | |||
| - apiGroups: [""] | |||
| resources: ["endpoints"] | |||
| verbs: ["get", "watch", "list", "delete", "update", "create"] | |||
| - apiGroups: ["coordination.k8s.io"] | |||
There was a problem hiding this comment.
And a comment that only one of endpoints or lease rules is needed
Signed-off-by: Andrew Sy Kim <[email protected]>
…ed leader election Signed-off-by: Andrew Sy Kim <[email protected]>
Signed-off-by: Andrew Sy Kim <[email protected]>
andrewsykim
force-pushed
the
leader-election
branch
from
92de551
to
736e67e
Compare
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Fix the failing multiarch builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for lease based leader election which is highly recommended over endpoints base. Endpoints based will be supported for a few releases for backwards compatibility.
/assign @msau42 @jsafrane @xing-yang