Use Connection() from util package #234
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jsafrane
force-pushed
the
use-lib-connection
branch
2 times, most recently
from
41d9159
to
a9543a0
Compare
| return "", fmt.Errorf("name is empty") | ||
| } | ||
| return name, nil | ||
| return connection.GetDriverName(ctx, conn) | ||
| } | ||
|
|
||
| func getDriverCapabilities(conn *grpc.ClientConn, timeout time.Duration) (sets.Int, error) { |
There was a problem hiding this comment.
and update getcapabilities?
jsafrane
force-pushed
the
use-lib-connection
branch
from
a9543a0
to
e63995f
Compare
|
cc @lpabon |
| } | ||
| switch service.GetType() { | ||
| for cap := range pluginCaps { | ||
| switch cap { |
There was a problem hiding this comment.
Is mixing plugin and controller capabilities into the same set correct? Could you have conflicts in values?
There was a problem hiding this comment.
PluginCapability_* and ControllerCapability_* are part of the same enum defined in the provisioner, they don't come from CSI:
external-provisioner/pkg/controller/controller.go
Lines 160 to 165 in e63995f
There was a problem hiding this comment.
Thanks for pointing that out. Is there a reason why it needs to have one more level of translation from CSI capabilities?
There was a problem hiding this comment.
Can we sort it out in a separate PR? I'd like to cache the capabilities so provisioner does not load them from the driver every time it needs them. Refactoring of the enum would be better there.
There was a problem hiding this comment.
Sure do you want to use csi-lib-utils 0.4.0-rc1 here?
There was a problem hiding this comment.
Updated to 0.4.0-rc1
jsafrane
force-pushed
the
use-lib-connection
branch
from
e63995f
to
2aeb480
Compare
jsafrane
force-pushed
the
use-lib-connection
branch
from
2aeb480
to
20cb5e5
Compare
k8s-ci-robot
added
the
lgtm
984feece4 Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
master: update release-tools
984feece4 Merge pull request #234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version b54c1ba49 Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81e9 Change go version to 1.21.5 267b40e97 Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2de nominate self (carlory) as kubernetes-csi reviewer a17f536fc Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033de2 Use set -x instead of die 5deaf667c Add wrapper script for sidecar release f8c8cc4c7 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bfdc Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc9a Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c4650889d pull-test.sh: avoid "git subtree pull" error 7b175a1e2 Update csi-test version to v5.2.0 987c90ccd Update go version to 1.21 to match k/k 2c625d41d Add script to generate patch release notes f9d5b9c05 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd5372 Bump csi-driver-host-path version up to v1.12.0 984feece4 Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644
The result should be the same as in kubernetes-csi/external-attacher#123