Skip to content

deploy: split out RBAC definitions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 23, 2018
Merged

deploy: split out RBAC definitions #84

k8s-ci-robot merged 1 commit into from
Oct 23, 2018

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented Oct 21, 2018

Splitting out the RBAC definitions into a separate file has the
advantage that it can be used as-is without editing in other
deployments. For example, the Kubernetes E2E test uses this file.

@pohly
deploy: split out RBAC definitions
49e4642 
Splitting out the RBAC definitions into a separate file has the
advantage that it can be used as-is without editing in other
deployments. For example, the Kubernetes E2E test uses this file.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2018
@pohly
Copy link
Contributor Author

pohly commented Oct 21, 2018

This rbac.yaml file is identical to the one in the E2E PR kubernetes/kubernetes#69868

A similar PR was filed against external-provisioner (kubernetes-csi/external-provisioner#156).

@jsafrane
Copy link
Contributor

jsafrane commented Oct 22, 2018

/lgtm

@pohly
Copy link
Contributor Author

pohly commented Oct 22, 2018

/assign @jsafrane

Please also approve so that tide can merge it.

@pohly
Copy link
Contributor Author

pohly commented Oct 22, 2018

@jsafrane hmm, the bot didn't pick up your lgtm (label is still missing). Does that have to come from one of the reviewers (@davidz627 or @sbezverk)?

@jsafrane
Copy link
Contributor

jsafrane commented Oct 22, 2018

github still has issues, "Webhooks and Pages builds remain paused."

@jsafrane
Copy link
Contributor

jsafrane commented Oct 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Oct 23, 2018

/approve

@jsafrane jsafrane closed this Oct 23, 2018
@jsafrane jsafrane reopened this Oct 23, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Oct 23, 2018

/lgtm
/approve
(sorry, wrong button :-)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 068527d into kubernetes-csi:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pohly @jsafrane @k8s-ci-robot