Skip to content

Update dependency go modules for k8s v1.26.0#395

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
sunnylovestiramisu:module-update-master
Dec 13, 2022
Merged

Update dependency go modules for k8s v1.26.0#395
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
sunnylovestiramisu:module-update-master

Conversation

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Dec 12, 2022 •
edited by jsafrane
Loading

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.26.0

Updated Kubernetes dependencies to 1.26.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2022
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor Author

sunnylovestiramisu commented Dec 12, 2022

/assign @msau42

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Dec 13, 2022

/release-label-node
/lgmt
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Dec 13, 2022

/release-label-none

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Dec 13, 2022

/release-note-none
?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2022
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Dec 13, 2022

/lgtm
bad day today :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3ef492c into kubernetes-csi:master Dec 13, 2022
@humblec
Copy link
Copy Markdown
Contributor

humblec commented Dec 13, 2022

@sunnylovestiramisu looks like some dependencies are still with rc tag https://github.com/kubernetes-csi/external-attacher/pull/395/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L17 or see #396 . considering you have filed PRs in sidecar repos, it would be better to revisit the existing PRs too

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Dec 13, 2022

@humblec good catch, I missed that one.

@humblec
Copy link
Copy Markdown
Contributor

humblec commented Dec 13, 2022

@humblec good catch, I missed that one.

yw 👍

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor Author

sunnylovestiramisu commented Dec 13, 2022

I was running the script go-get-kubernetes.sh and this is what the script generated. Do we usually manually update dependencies after running the script? It happened twice already for both 1.26.0-rc and 1.26.0.

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Dec 13, 2022
Closed
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Dec 13, 2022

I think it's worth digging more into the script to figure out why it's not updating those. We want to get to a state where the script is reliable and doesn't require modifying by hand afterwards

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2022
@mpatlasov mpatlasov mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@j-griffith j-griffith Awaiting requested review from j-griffith

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sunnylovestiramisu @jsafrane @k8s-ci-robot @humblec @msau42