Skip to content

Use registry.k8s.io for deployment#372

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
AdityaC45:UpdateImageName
Sep 1, 2022
Merged

Use registry.k8s.io for deployment#372
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
AdityaC45:UpdateImageName

Conversation

@AdityaC45
Copy link
Copy Markdown
Contributor

@AdityaC45 AdityaC45 commented Aug 27, 2022 •
edited
Loading

What type of PR is this?
/kind feature
/label release-note-none

What this PR does / why we need it:

Related to:
kubernetes-csi/external-snapshotter#687
Switch to the new endpoint for container images. See: https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)

Special notes for your reviewer:
registry.k8s.io is currently a redirect to k8s.gcr.io. The change should be transparent to any pulling from k8s.gcr.io.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2022

Welcome @AdityaC45!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 27, 2022

Hi @AdityaC45. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2022
jsafrane
jsafrane reviewed Aug 29, 2022
View reviewed changes
Comment thread deploy/kubernetes/deployment.yaml Outdated
containers:
- name: csi-attacher
image: gcr.io/k8s-staging-sig-storage/csi-attacher:canary
image: registry.k8s.io/k8s-staging-sig-storage/csi-attacher:canary
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use registry.k8s.io/sig-storage/csi-attacher:v3.5.0. I don't see :canary builds in registry.k8s.io.

Copy link
Copy Markdown
Contributor Author

@AdityaC45 AdityaC45 Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I didn't check that, will update this PR

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Aug 29, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2022
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Aug 30, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdityaC45, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@humblec
Copy link
Copy Markdown
Contributor

humblec commented Aug 31, 2022

/release-note-none

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 31, 2022

@humblec: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

Details

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec
Copy link
Copy Markdown
Contributor

humblec commented Aug 31, 2022

@AdityaC45 can you correct the release note section in the PR description ?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 1, 2022

@AdityaC45: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

Details

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdityaC45
Copy link
Copy Markdown
Contributor Author

AdityaC45 commented Sep 1, 2022

/kind cleanup
/release-note-none

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 1, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 1, 2022

@AdityaC45: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

Details

In response to this:

/kind cleanup
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdityaC45
Copy link
Copy Markdown
Contributor Author

AdityaC45 commented Sep 1, 2022 •
edited
Loading

/remove-kind deprecation

@k8s-ci-robot k8s-ci-robot removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Sep 1, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 1, 2022

@AdityaC45: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

Details

In response to this:

/remove-kind deprecation
/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdityaC45
Copy link
Copy Markdown
Contributor Author

AdityaC45 commented Sep 1, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 37da3be into kubernetes-csi:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@humblec humblec Awaiting requested review from humblec

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AdityaC45 @k8s-ci-robot @jsafrane @humblec