Map PV access modes to CSI access modes based on driver capability #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
chrishenzie
force-pushed
the
single-node-access-modes
branch
from
fd63e4c
to
ab0e373
Compare
jsafrane
reviewed
May 18, 2021
chrishenzie
force-pushed
the
single-node-access-modes
branch
from
ab0e373
to
69fb259
Compare
chrishenzie
force-pushed
the
single-node-access-modes
branch
2 times, most recently
from
dc26ef0
to
e4c4d38
Compare
jsafrane
reviewed
Jun 3, 2021
vendor/github.com/kubernetes-csi/csi-lib-utils/accessmodes/access_modes.go
Outdated
Show resolved
Hide resolved
chrishenzie
force-pushed
the
single-node-access-modes
branch
2 times, most recently
from
887792f
to
f4499f0
Compare
chrishenzie
force-pushed
the
single-node-access-modes
branch
3 times, most recently
from
032fd34
to
282fa01
Compare
chrishenzie
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Rebased on #317 which is blocked on release of v1.22. |
k8s-ci-robot
added
do-not-merge/hold
chrishenzie
force-pushed
the
single-node-access-modes
branch
from
282fa01
to
5c66da5
Compare
k8s-ci-robot
added
size/L
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
chrishenzie
force-pushed
the
single-node-access-modes
branch
from
5c66da5
to
00dde3e
Compare
chrishenzie
force-pushed
the
single-node-access-modes
branch
from
00dde3e
to
bbc9af1
Compare
|
@jsafrane PTAL, this is ready for review |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
See KEP#2485 for more details.
This PR introduces mappings between Kubernetes PV access modes and CSI access modes. If the CSI driver supports the
SINGLE_NODE_MULTI_WRITERcontroller capability, map ReadWriteOnce toSINGLE_NODE_MULTI_WRITERand ReadWriteOncePod toSINGLE_NODE_SINGLE_WRITER. If the CSI driver does not support this controller capability, map ReadWriteOnce toSINGLE_NODE_WRITER(current behavior preserved for backwards compatibility).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The CSI spec change PR#476 is here and just requires merging. Until then, I have a placeholder commit using my forked version of the CSI spec.
Similarly for K8s, the API change and feature addition PR#102028 is here and still is in the early stages of review. Until then, I have a placeholder commit using my forked version of the K8s API.
Does this PR introduce a user-facing change?:
/assign @msau42
/assign @jingxu97