Skip to content

added labels to the resources to be used for collective operation#274

Closed
aayushrangwala wants to merge 1 commit intokubernetes-csi:masterfrom
aayushrangwala:master
Closed

added labels to the resources to be used for collective operation#274
aayushrangwala wants to merge 1 commit intokubernetes-csi:masterfrom
aayushrangwala:master

Conversation

@aayushrangwala
Copy link
Copy Markdown

What type of PR is this?
/kind feature

What this PR does / why we need it:
We need to add the common/generic labels to all the resources which are being deployed as the part of any csi driver. It is the part of this PR

Special notes for your reviewer:
Since there was no common labels to identify all the items in one set of resources installed, these labels can help us to identify resources and operate on them in a collective manner

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aayushrangwala
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @aayushrangwala!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @aayushrangwala. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aayushrangwala
Copy link
Copy Markdown
Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 10, 2020
@aayushrangwala
Copy link
Copy Markdown
Author

//cc @pohly

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 10, 2020
@aayushrangwala
Copy link
Copy Markdown
Author

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@aayushrangwala: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-attacher that referenced this pull request May 5, 2025
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-attacher that referenced this pull request Jul 4, 2025
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-attacher that referenced this pull request Jul 7, 2025
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants