Remove update from rbac. It has been replaced by patch#230
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom May 6, 2020
Merged
Remove update from rbac. It has been replaced by patch#230k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Collaborator
Author
|
/assign @jsafrane |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
humblec
added a commit
to humblec/external-attacher
that referenced
this pull request
Aug 1, 2023
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
Sneha-at
added a commit
to Sneha-at/external-attacher
that referenced
this pull request
Aug 2, 2023
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version git-subtree-dir: release-tools git-subtree-split: 1df23dba61da5d4e52ae79e6e1571f9d1d94311d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
All Update() calls have been replaced by Patch(), so the rbac is no longer needed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: