Skip to content

Exit on connection loss#182

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:die-on-connection-loss
Sep 17, 2019
Merged

Exit on connection loss#182
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
jsafrane:die-on-connection-loss

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Sep 17, 2019 •
edited
Loading

Exist when a driver closes its socket.

  1. The attacher caches driver capabilities, which could (in theory) change
    after driver restart.

  2. New driver may not come up for a while and the attacher should not act
    as leader during this time.

/kind cleanup

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The external attacher now exits when it looses connection to a CSI driver. This speeds up re-election of a new attacher leader that has connection to the driver.

@jsafrane
Exit on connection loss
ee70752 
Exist when a driver closes its socket.

1. The attacher caches driver capabilities, which could (in theory) change
after driver restart.

2. New driver may not come up for a while and the attacher should not act
as leader during this time.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2019
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Sep 17, 2019

@pohly @msau42, PTAL

I'd prefer to have this in upcoming 2.0 release (for Kubernetes 1.16).

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Sep 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9f5902f into kubernetes-csi:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsafrane @k8s-ci-robot @msau42