Skip to content

Update csi-release-tools#180

Merged
k8s-ci-robot merged 11 commits intokubernetes-csi:masterfrom
msau42:prow-update-master
Sep 9, 2019
Merged

Update csi-release-tools#180
k8s-ci-robot merged 11 commits intokubernetes-csi:masterfrom
msau42:prow-update-master

Conversation

@msau42
Copy link
Copy Markdown
Collaborator

@msau42 msau42 commented Sep 7, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Picks up the following changes:

  • Update kind to v0.5.0
  • Enables Windows builds
  • Enables dep testing in prow
  • Creates kind cluster with 2 nodes to help test topology

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

msau42 and others added 11 commits August 21, 2019 15:19
Signed-off-by: Deep Debroy <ddebroy@docker.com>
Add rule for building Windows binaries
"make test-vendor" depends on dep if the current project uses
dep. Without it, the vendor directory checking was skipped under Prow.
…h driver

Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
…ind-cluster

Create 2-node kind cluster since topology support is added to hostpath
build windows binaries with .exe suffix
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 7, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2019
@msau42
Copy link
Copy Markdown
Collaborator Author

msau42 commented Sep 7, 2019

/assign @jsafrane

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2019
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Sep 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0acde82 into kubernetes-csi:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants