1.0: Fixed ControllerUnpublish error handling#170
Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:release-1.0from Aug 12, 2019
Merged
1.0: Fixed ControllerUnpublish error handling#170k8s-ci-robot merged 2 commits intokubernetes-csi:release-1.0from
k8s-ci-robot merged 2 commits intokubernetes-csi:release-1.0from
Conversation
Any error from ControllerUnpublish can mean that a volume could be still attached (or being detached).
The attacher should retry ControllerUnpublish after error. At the same time, we do not want to change behavior of NotFound handling in stable branches, so treat it as no error.
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jsafrane
changed the title
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
This is backport of #165 into 1.0 branch.
I added extra code to interpret
NotFoundas success (i.e. a volume is considered as detached), so behavior ofNotFounderror handling is not changed in a stable branch./assign @msau42