Skip to content

Add 1.2 changelog with notable feature of inline volume migration#155

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
davidz627:fix/changelog
Jun 21, 2019
Merged

Add 1.2 changelog with notable feature of inline volume migration#155
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
davidz627:fix/changelog

Conversation

@davidz627
Copy link
Copy Markdown
Contributor

@davidz627 davidz627 commented Jun 12, 2019 •
edited
Loading

/kind documentation

/assign @ddebroy

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 June 12, 2019 01:07
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2019
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Jun 12, 2019

/assign @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2019
@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Jun 12, 2019

/assign @jsafrane

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Jun 13, 2019

The external attacher moved from POST to PATCH and RBAC has been updated. I added release-note text to #149 just now, please regenerate.

@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Jun 13, 2019

@jsafrane done

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2019
@ddebroy
Copy link
Copy Markdown
Contributor

ddebroy commented Jun 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2019
msau42
msau42 reviewed Jun 14, 2019
View reviewed changes
Comment thread CHANGELOG-1.2.md Outdated
## Notable Features

* Support attachment of inline volumes migrated to CSI [#153](https://github.com/kubernetes-csi/external-attacher/pull/154)
* Action required: PATCH is used instead of POST to modify VolumeAttachments on API servers. Please note changes in the external attacher RBAC policy. [#149](https://github.com/kubernetes-csi/external-attacher/pull/149)
Copy link
Copy Markdown
Collaborator

@msau42 msau42 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is considered a breaking change as part of our still yet to be finalized upgrade policy, ie you can't upgrade just the container image. In fact, our canary tests are failing maybe because of this? https://k8s-testgrid.appspot.com/sig-storage-csi#canary-on-1-14

How much do we really want this change? If we want to keep it, we may need to bump the major version.

Copy link
Copy Markdown
Contributor Author

@davidz627 davidz627 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it was causing GCE PD tests to fail as well. Better to rip off the bandaid quickly rather than leave it for later?
I already updated the RBAC for PD to include PATCH as well :)

Copy link
Copy Markdown
Collaborator

@msau42 msau42 Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep the change, then we should call this release 2.0 to indicate that you may need to take some other actions to make it work.

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Jun 18, 2019

I'm reverting PATCH in #157 and updated release note of the original PR, please regenerate again when it gets merged :-(.

msau42
msau42 reviewed Jun 18, 2019
View reviewed changes
Comment thread CHANGELOG-1.2.md Outdated
* Support attachment of inline volumes migrated to CSI [#153](https://github.com/kubernetes-csi/external-attacher/pull/154)
* Action required: PATCH is used instead of POST to modify VolumeAttachments on API servers. Please note changes in the external attacher RBAC policy. [#149](https://github.com/kubernetes-csi/external-attacher/pull/149)

## Other notable changes
Copy link
Copy Markdown
Collaborator

@msau42 msau42 Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some other changes that I think are worth including too. We should use the release-note tool starting from commit e157b6b.

Copy link
Copy Markdown
Collaborator

@msau42 msau42 Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current instructions are here: kubernetes-csi/docs#142 (comment)

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Jun 20, 2019

README should be updated to bump K8s version to 1.15

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@davidz627
Copy link
Copy Markdown
Contributor Author

davidz627 commented Jun 21, 2019

@msau42 resolved with release tool

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Jun 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 834bae5 into kubernetes-csi:master Jun 21, 2019
@davidz627 davidz627 deleted the fix/changelog branch June 21, 2019 22:43
This was referenced Apr 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@ddebroy ddebroy

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidz627 @msau42 @jsafrane @ddebroy @k8s-ci-robot