update rbac for secret

[hoyho]

What type of PR is this?

/kind bug

What this PR does / why we need it:
Attach will be fail when StorageClass specific parameters csi.storage.k8s.io/controller-publish-secret-name and csi.storage.k8s.io/controller-publish-secret-namespace

Which issue(s) this PR fixes:

Fixes #88

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

[k8s-ci-robot]

Welcome @hoyho!

It looks like this is your first PR to kubernetes-csi/external-attacher 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-attacher has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @hoyho. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hoyho]

Does the external-attacher need other permission？ Currently it has verbs: ["get", "list"] @jsafrane

[msau42]

Can we make these optional with a comment? Not all drivers are going to need it and we want to reduce rbac permissions as much as possible by default.

[hoyho]

Ok, sounds good. Since there's no secret permission by default, should we also add a note at https://github.com/kubernetes-csi/docs/blob/master/book/src/secrets-and-credentials.md#secrets-and-credentials to remind people to enable here?

[msau42]

Yes, that's a great idea!

[msau42]

/ok-to-test

[msau42]

/lgtm
/approve
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoyho, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment