Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation on the external-snaphot-metadata sidecar (alpha). #605

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Documentation on the external-snaphot-metadata sidecar (alpha). #605

merged 1 commit into from
Feb 12, 2025

Conversation

carlbraganza
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2024
@PrasadG193 PrasadG193 mentioned this pull request Oct 22, 2024
Closed
nixpanic
nixpanic reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the references to the KEP (like the CR, "Risks and Mitigations") could be included here directly, it'll be a much simpler read for the users.

@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch from b5fd8df to 8c9996b Compare January 15, 2025 18:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2025
@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch 3 times, most recently from 9fea794 to 4c157ba Compare January 15, 2025 21:32
@carlbraganza carlbraganza requested a review from nixpanic January 15, 2025 21:34
@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch 2 times, most recently from 3f3e5b0 to b5a4524 Compare January 15, 2025 21:43
@carlbraganza
Copy link
Contributor Author

The documentation has been updated to reflect the alpha version of v0.1.0.
Links to images and references to the hostpath CSI driver are slightly premature as they depend pending PRs and cutting the alpha release.
I'll remove the draft mode once this is done.

@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch from b5a4524 to 7a41ef4 Compare January 17, 2025 18:45
@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch from 7a41ef4 to 0d6ca24 Compare January 17, 2025 19:47
@carlbraganza
Copy link
Contributor Author

@nixpanic @Rakshith-R Thanks for the feedback so far.

I've reshuffled some material slightly by adding a "Resources" section to clearly identify programming artifacts available to application developers and CSI driver developers. I think it will make things much more obvious.

I've also tried to be consistent with the naming, and reduce hyperlinks to just 1 per section.

Rakshith-R
Rakshith-R approved these changes Jan 22, 2025
View reviewed changes
Copy link

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@carlbraganza carlbraganza marked this pull request as ready for review January 24, 2025 20:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali January 24, 2025 20:11
@carlbraganza carlbraganza force-pushed the snapshot-metadata-sidecar-alpha branch from 0d6ca24 to 7f30a33 Compare February 5, 2025 19:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@carlbraganza
Copy link
Contributor Author

Updated to K8s version 1.33

@nixpanic
Copy link
Member

nixpanic commented Feb 6, 2025

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@nixpanic
Copy link
Member

nixpanic commented Feb 6, 2025

/unassign
/assign xing-yang

@k8s-ci-robot k8s-ci-robot assigned xing-yang and unassigned nixpanic Feb 6, 2025
@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 12, 2025
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlbraganza, Rakshith-R, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 306ba63 into kubernetes-csi:master Feb 12, 2025
3 checks passed
@Rakshith-R Rakshith-R mentioned this pull request Feb 24, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@lpabon lpabon Awaiting requested review from lpabon

@nixpanic nixpanic Awaiting requested review from nixpanic

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@Rakshith-R Rakshith-R

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlbraganza @nixpanic @xing-yang @k8s-ci-robot @Rakshith-R