Check CSI sidecar supported versions#227
Conversation
|
/release-note-none |
ggriffiths
left a comment
There was a problem hiding this comment.
/lgtm, looks good to me! Thanks for adding this!
|
/lgtm |
|
Thanks @ggriffiths. |
mauriciopoppe
left a comment
There was a problem hiding this comment.
Thanks for taking the time to write this tool. If there's tooling outside the usual bash scripts/makefile scripts I think all of our repos are written in go so it'd make sense to write tooling in go too.
| from collections import defaultdict | ||
| import subprocess | ||
| import shutil | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
If this is an external dependency I think it needs to have a pip install command somewhere but it's a dev only tool so I think it's good.
Also consider that this file is going to be synced to all the CSI repos.
There was a problem hiding this comment.
collections is a built-in ; dateutil is an external dependency.
Next time I work on it I will replace it with just built-in ;-)
Yes, you'll need @jsafrane for an approval review. I can only provide LGTM :) |
|
/assign @jsafrane |
I think there are some K8s scripts out there written in a Python. It's a much better language than bash or go for this use case. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coulof, ggriffiths, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -0,0 +1,170 @@ | |||
| # Copyright 2023 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Some repos have codespell enabled as a github action which failed when this change was synced to the other repos, could you please review these errors?
Resulting CLI options --check-filenames --skip ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh
3
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:35: ouputs ==> outputs
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:101: relase ==> release
That script is a helper to update the tables from : https://kubernetes-csi.github.io/docs/sidecar-containers.html
The next goal is to generate the tables from the release pages but... we have to agree upon the metadata and fix the typos :-) (cf. https://github.com/kubernetes-csi/external-attacher/releases with
docker pull docker pull registry.k8s.io/sig-storage/csi-attacher:v4.3.0)