Skip to content

Update cloudbuild image#224

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
msau42:cloudbuild
Apr 25, 2023
Merged

Update cloudbuild image#224
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
msau42:cloudbuild

Conversation

@msau42
Copy link
Copy Markdown
Collaborator

@msau42 msau42 commented Apr 25, 2023

Try to fix build failures:
https://storage.googleapis.com/kubernetes-jenkins/logs/post-external-provisioner-push-images/1650605297175105536/build-log.txt

Looks like go 1.20 added a new requirement to dynamically link to libresolv.so, and our image builder is based on alpine which doesn't support it:
golang/go#59305

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from humblec and pohly April 25, 2023 03:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2023
@msau42
Copy link
Copy Markdown
Collaborator Author

msau42 commented Apr 25, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 25, 2023
Comment thread cloudbuild.yaml Outdated
# the desired version of Go (currently defined in release-tools/prow.sh),
# but that just speeds up the build and is not required.
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20210917-12df099d55'
- name: 'gcr.io/k8s-testimages/gcb-docker-gcloud'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go version in the latest gcb-docker-gcloud image is 1.20 so we will skip the download and extraction step:

# go version
go version go1.20.3 linux/amd64

However, if I try to follow the steps when the version doesn't match and download and extract the go binary, I get the linking errors:

# ./go version
Error loading shared library libresolv.so.2: No such file or directory (needed by ./go)
e3b2f0ad2780:/workspace/go/go/bin# ldd ./go
        /lib64/ld-linux-x86-64.so.2 (0x7f1ab8911000)
Error loading shared library libresolv.so.2: No such file or directory (needed by ./go)
        libpthread.so.0 => /lib64/ld-linux-x86-64.so.2 (0x7f1ab8911000)
        libc.so.6 => /lib64/ld-linux-x86-64.so.2 (0x7f1ab8911000)

So we are ok for now, but this will fail in the future when we update the go version again.

Copy link
Copy Markdown
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants