Updating go to v1.20 by marosset · Pull Request #289 · kubernetes-csi/csi-proxy

marosset · 2023-07-20T22:17:30Z

/kind cleanup

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updating golang to v1.20

Signed-off-by: Mark Rossetti <marosset@microsoft.com>

k8s-ci-robot · 2023-07-20T22:17:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset
Once this PR has been reviewed and has the lgtm label, please assign patricklang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-07-20T22:17:39Z

Hi @marosset. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mauriciopoppe · 2023-07-20T23:45:08Z

/ok-to-test

mauriciopoppe · 2023-07-20T23:49:59Z

Presubmit failed with:

{  
Repo uses 'go mod'.
+ env GO111MODULE=on go mod tidy
go: go.mod file indicates go 1.20, but maximum version supported by tidy is 1.19
ERROR: vendor check failed.
    }

The go version is coming from release-tools, I think we need to sync that repo here before doing this change

c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 4133d1d Merge pull request kubernetes-csi#226 from msau42/cloudbuild 8d519d2 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest 6e04a03 Merge pull request kubernetes-csi#224 from msau42/cloudbuild 26fdfff Update cloudbuild image 6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae99 Update k8s image repo url 77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b Fix dep version mismatch 8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94d Update go version to 1.20 to match k/k v1.27 e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a512 test: fix golint error aa61bfd Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d19 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171be Merge pull request kubernetes-csi#216 from msau42/process cb98782 Merge pull request kubernetes-csi#217 from msau42/owners a11216e add new reviewers and remove inactive reviewers dd98675 Add step for checking builds b66c082 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763 filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d427783 filter-junit.go: preserve system error log 38e1146 prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: c10b67804e07a324fe33595040afd13f020ee000

go.mod

mauriciopoppe · 2023-07-25T17:16:36Z

We updated release-tools in #290, please rebase when you get the chance.

There are also some codespell false negatives:

Resulting CLI options  --check-filenames --skip ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh
3
Error: ./integrationtests/csi_api_gen_test.go:19: bootstraping ==> bootstrapping
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:35: ouputs ==> outputs
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:101: relase ==> release

Could you please also add release-tools/contrib/*.py to

csi-proxy/.github/workflows/codespell.yml

Line 15 in fb21c30

    
           skip: ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh

.

There's also this failure:

Run go get -u github.com/golang/protobuf/{proto,protoc-gen-go}
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
Error: Process completed with exit code 1.

We need to update a few scripts that were doing go get to go install.

Sorry about all of these failures! We haven't received a PR in a long time for this project so it got out of date, if you don't have the bandwidth then we can take it, just let us know.

marosset · 2023-07-25T17:25:10Z

er

We updated release-tools in #290, please rebase when you get the chance.

There are also some codespell false negatives:
Resulting CLI options  --check-filenames --skip ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh
3
Error: ./integrationtests/csi_api_gen_test.go:19: bootstraping ==> bootstrapping
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:35: ouputs ==> outputs
Error: ./release-tools/contrib/get_supported_version_csi-sidecar.py:101: relase ==> release
Could you please also add release-tools/contrib/*.py to

csi-proxy/.github/workflows/codespell.yml

Line 15 in fb21c30

skip: ./.git,./.github/workflows/codespell.yml,.git,*.png,*.jpg,*.svg,*.sum,./vendor,go.sum,./release-tools/prow.sh

.
There's also this failure:
Run go get -u github.com/golang/protobuf/{proto,protoc-gen-go}
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
Error: Process completed with exit code 1.
We need to update a few scripts that were doing go get to go install.

Sorry about all of these failures! We haven't received a PR in a long time for this project so it got out of date, if you don't have the bandwidth then we can take it, just let us know.

No problem.
I also just submitted a fix into csi-release-tools to fix the codespell errors.

@mauriciopoppe - if you have bandwidth to address to go get installs I'd appreciate it!

mauriciopoppe · 2023-07-25T19:24:44Z

I also just submitted a fix into csi-release-tools to fix the codespell errors.

Thanks, it takes some time to bring that repo into all of the CSI repos so we might need to make that change in this repo too.

if you have bandwidth to address to go get installs I'd appreciate it!

Sure, I'll work on both codespell/go get in a new commit

k8s-ci-robot · 2023-07-26T06:36:13Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mauriciopoppe · 2023-07-26T13:58:02Z

I made the go 1.20 change too in #292

marosset · 2023-07-27T02:58:02Z

I made the go 1.20 change too in #292

thanks @mauriciopoppe!

Updating go to v1.20

d40d641

Signed-off-by: Mark Rossetti <marosset@microsoft.com>

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2023

k8s-ci-robot requested review from chrishenzie and pohly July 20, 2023 22:17

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2023

marosset added 2 commits July 25, 2023 09:48

Merge commit 'b8ebb685684ea6fb1bae9736b74bf98e48c85e52' into go-1-20

57c5d2c

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2023

micahhausler mentioned this pull request Jul 25, 2023

Update Go version and dependencies #291

Closed

micahhausler reviewed Jul 25, 2023

View reviewed changes

go.mod Show resolved Hide resolved

marosset mentioned this pull request Jul 25, 2023

fixing some codespell errors kubernetes-csi/csi-release-tools#229

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2023

mauriciopoppe closed this Jul 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating go to v1.20#289

Updating go to v1.20#289
marosset wants to merge 3 commits intokubernetes-csi:masterfrom
marosset:go-1-20

marosset commented Jul 20, 2023

Uh oh!

k8s-ci-robot commented Jul 20, 2023

Uh oh!

k8s-ci-robot commented Jul 20, 2023

Uh oh!

mauriciopoppe commented Jul 20, 2023

Uh oh!

mauriciopoppe commented Jul 20, 2023

Uh oh!

Uh oh!

mauriciopoppe commented Jul 25, 2023

Uh oh!

marosset commented Jul 25, 2023

Uh oh!

mauriciopoppe commented Jul 25, 2023

Uh oh!

k8s-ci-robot commented Jul 26, 2023

Uh oh!

mauriciopoppe commented Jul 26, 2023

Uh oh!

marosset commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

marosset commented Jul 20, 2023

Uh oh!

k8s-ci-robot commented Jul 20, 2023

Uh oh!

k8s-ci-robot commented Jul 20, 2023

Uh oh!

mauriciopoppe commented Jul 20, 2023

Uh oh!

mauriciopoppe commented Jul 20, 2023

Uh oh!

Uh oh!

mauriciopoppe commented Jul 25, 2023

Uh oh!

marosset commented Jul 25, 2023

Uh oh!

mauriciopoppe commented Jul 25, 2023

Uh oh!

k8s-ci-robot commented Jul 26, 2023

Uh oh!

mauriciopoppe commented Jul 26, 2023

Uh oh!

marosset commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants