feat: migrate smb API group to library model#245
Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom Oct 13, 2022
Merged
feat: migrate smb API group to library model#245k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XL
Contributor
Author
|
/cc @mauriciopoppe |
| b[i] = charset[seededRand.Intn(len(charset))] | ||
| } | ||
| return string(b) | ||
| func TestSmbAPIGroup(t *testing.T) { |
integrationtests/utils.go
Outdated
|
|
||
| var seededRand = rand.New(rand.NewSource(time.Now().UnixNano())) | ||
|
|
||
| func stringWithCharset(length int, charset string) string { |
Member
There was a problem hiding this comment.
These are utils not used by any other integration test, I'd limit the scope of these functions to be inside the SMB test
I think volumeInit was used in many API Groups so I guess that one is ok
Contributor
Author
There was a problem hiding this comment.
moved back in latest commit :)
Member
|
Saw this in the last run: /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Part of #217 (migrating one API Group to v2's library based model). The v1 model will stick around until all API groups are migrated.
Which issue(s) this PR fixes:
Fixes #237
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Deferring release note till all API groups are migrated.