Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc, klog, protobuf to latest versions #172

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 11, 2021

Signed-off-by: Humble Chirammal [email protected]

In this release, the grpc, klog, protobuf dependencies of server and client modules are updated to latest versions which address many bug fixes and enhancements in its own. 

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 11, 2021
@humblec
Copy link
Contributor Author

humblec commented Aug 11, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 11, 2021
@humblec
Copy link
Contributor Author

humblec commented Aug 11, 2021

/assign @ddebroy
/assign @jingxu97
/assign @ggriffiths

@ggriffiths
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
go.mod Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@humblec humblec changed the title Update grpc, klog to latest versions Update grpc, klog, protobuf to latest versions Aug 12, 2021
@mauriciopoppe
Copy link
Member

mauriciopoppe commented Aug 12, 2021

/lgtm

Please add a release note too

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 12, 2021
@humblec
Copy link
Contributor Author

humblec commented Aug 12, 2021

/lgtm

Please add a release note too

@mauriciopoppe done.. ptal, and I am ready to change if needed. 👍 .. Thanks!

@humblec
Copy link
Contributor Author

humblec commented Aug 16, 2021

@mauriciopoppe may be you can approve too?

@mauriciopoppe
Copy link
Member

@jingxu97
Copy link
Contributor

@humblec thanks for the PR! Just want to double check whether you tested the binary after upgrading the versions? Thanks!

@humblec
Copy link
Contributor Author

humblec commented Aug 18, 2021

@humblec thanks for the PR! Just want to double check whether you tested the binary after upgrading the versions? Thanks!

@jingxu97 it is shaming to admit I havent tested the binary on top of this PR. Unfortunately, I dont have a setup where I can quickly test the same. If at all I can ask, can anyone help here :)

@mauriciopoppe
Copy link
Member

I had the chance to run the integration tests using this branch in a VM, the ones that don't run in Github Actions (Disk and Volume) passed:

--- PASS: TestVolumeAPIs (199.74s)
    --- PASS: TestVolumeAPIs/NegativeDiskTests (0.02s)
    --- PASS: TestVolumeAPIs/NegativeVolumeTests (11.96s)
    --- PASS: TestVolumeAPIs/v1alpha1Tests (41.65s)
    --- PASS: TestVolumeAPIs/v1beta1Tests (46.51s)
    --- PASS: TestVolumeAPIs/v1beta2Tests (46.51s)
    --- PASS: TestVolumeAPIs/v1beta3Tests (53.10s)
PASS
ok      github.com/kubernetes-csi/csi-proxy/integrationtests    200.198s

--- PASS: TestDiskAPIGroup (181.75s)
    --- PASS: TestDiskAPIGroup/v1beta3Tests (59.00s)
        --- PASS: TestDiskAPIGroup/v1beta3Tests/ListDiskIDs,ListDiskLocations (6.50s)
        --- PASS: TestDiskAPIGroup/v1beta3Tests/Get/SetDiskState (34.92s)
        --- PASS: TestDiskAPIGroup/v1beta3Tests/PartitionDisk (17.59s)
    --- PASS: TestDiskAPIGroup/v1beta2Tests (59.24s)
        --- PASS: TestDiskAPIGroup/v1beta2Tests/ListDiskIDs,ListDiskLocations (5.34s)
        --- PASS: TestDiskAPIGroup/v1beta2Tests/Get/SetDiskState (35.89s)
        --- PASS: TestDiskAPIGroup/v1beta2Tests/PartitionDisk (18.00s)
    --- PASS: TestDiskAPIGroup/v1beta1Tests (40.90s)
        --- PASS: TestDiskAPIGroup/v1beta1Tests/ListDiskIDs,ListDiskLocations (5.24s)
        --- PASS: TestDiskAPIGroup/v1beta1Tests/Get/SetDiskState (17.79s)
        --- PASS: TestDiskAPIGroup/v1beta1Tests/PartitionDisk (17.87s)
    --- PASS: TestDiskAPIGroup/v1alpha1Tests (22.61s)
        --- PASS: TestDiskAPIGroup/v1alpha1Tests/ListDiskLocations (2.58s)
        --- PASS: TestDiskAPIGroup/v1alpha1Tests/Rescan (2.46s)
        --- PASS: TestDiskAPIGroup/v1alpha1Tests/PartitionDisk (17.57s)
PASS
ok      github.com/kubernetes-csi/csi-proxy/integrationtests    182.075s

All the integration tests are passing @jingxu97 @ddebroy
/lgtm

@humblec
Copy link
Contributor Author

humblec commented Sep 3, 2021

Thanks @mauriciopoppe 👍 !

@humblec
Copy link
Contributor Author

humblec commented Sep 3, 2021

@jingxu97 ptal , thanks

@jingxu97
Copy link
Contributor

jingxu97 commented Sep 9, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8612e9e into kubernetes-csi:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants