-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpc, klog, protobuf to latest versions #172
Conversation
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
/release-note-none |
/assign @ddebroy |
/lgtm |
Signed-off-by: Humble Chirammal <[email protected]>
/lgtm Please add a release note too |
@mauriciopoppe done.. ptal, and I am ready to change if needed. 👍 .. Thanks! |
@mauriciopoppe may be you can approve too? |
@humblec thanks for the PR! Just want to double check whether you tested the binary after upgrading the versions? Thanks! |
@jingxu97 it is shaming to admit I havent tested the binary on top of this PR. Unfortunately, I dont have a setup where I can quickly test the same. If at all I can ask, can anyone help here :) |
I had the chance to run the integration tests using this branch in a VM, the ones that don't run in Github Actions (Disk and Volume) passed:
All the integration tests are passing @jingxu97 @ddebroy |
Thanks @mauriciopoppe 👍 ! |
@jingxu97 ptal , thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Humble Chirammal [email protected]