Send arrays to ConvertTo-Json in the internal disk implementation #154
Conversation
k8s-ci-robot
added
do-not-merge/hold
mauriciopoppe
changed the title
mauriciopoppe
force-pushed
the
single-disk-json
branch
from
b2fdf07 to
700566d
Compare
k8s-ci-robot
added
size/S
|
I've also checked the other places in /unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -93,8 +93,8 @@ func (DiskAPI) ListDiskLocations() (map[uint32]shared.DiskLocation, error) { | |||
|
|
|||
| m := make(map[uint32]shared.DiskLocation) | |||
| for _, v := range getDisk { | |||
| str := v["location"].(string) | |||
| num := v["number"].(float64) | |||
| str := v["Location"].(string) | |||
There was a problem hiding this comment.
why change location --> Location?
There was a problem hiding this comment.
this change is actually not needed and I can revert it back, it's because I also changed this line above:
cmd := fmt.Sprintf("ConvertTo-Json @(Get-Disk | select Number, Location)")
There was a problem hiding this comment.
I think I can skip making this change, I already run the integration tests on #155 and they're passing with the v1 API too
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
What this PR does / why we need it:
Context #153, we're using
ConvertTo-Json @(...)instead of pipesWhich issue(s) this PR fixes:
Fixes #153
Does this PR introduce a user-facing change?:
/hold
/cc @jingxu97 @ddebroy
We should merge #152 first