Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code in connection package #31

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove duplicate code in connection package #31

merged 1 commit into from
Jul 23, 2019

Conversation

Madhu-1
Copy link
Contributor

@Madhu-1 Madhu-1 commented Jul 19, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
There are duplicate functions present in both rpc and connection package. This PR removes the duplicate code from connection package.

Signed-off-by: Madhu Rajanna [email protected]

Which issue(s) this PR fixes:

Fixes #30

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The rpc and connection package has the same code, removed duplicate code from connection package. connection package will have the code related to RPC connection

@Madhu-1
Remove duplicate code in connection package
b2c8bfa 
There are duplicate functions present in
both rpc and connection package. This PR
removes the duplicate code from connection
package.

Signed-off-by: Madhu Rajanna <[email protected]>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2019
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jul 19, 2019

/assign @msau42

@pohly
Copy link
Contributor

pohly commented Jul 22, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2019
pohly
pohly requested changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog needs to be updated. The second sentence should be "The rpc package has the same code."

@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Jul 22, 2019

@pohly Thanks for the review, updated changelog

@pohly
Copy link
Contributor

pohly commented Jul 23, 2019

/kind cleanup
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0329e57 into kubernetes-csi:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

duplicate functions in connection and rpc package
4 participants
@Madhu-1 @k8s-ci-robot @pohly @msau42