Skip to content

feat: allow csi controllers to use client-go's leader election label functionality#200

Merged
k8s-ci-robot merged 3 commits intokubernetes-csi:masterfrom
DerekFrank:leader-election-leases
Oct 6, 2025
Merged

feat: allow csi controllers to use client-go's leader election label functionality#200
k8s-ci-robot merged 3 commits intokubernetes-csi:masterfrom
DerekFrank:leader-election-leases

Conversation

@DerekFrank
Copy link
Copy Markdown
Contributor

@DerekFrank DerekFrank commented Jun 17, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

This PR allows consumers of csi-lib-utils to leverage client-go's lease label functionality: kubernetes/kubernetes#131632

Which issue(s) this PR fixes:

Fixes #194

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Users can now specify custom labels that will be set on the underlying k8s lease object when a new leader is elected

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @DerekFrank!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @DerekFrank. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 17, 2025
@AndrewSirenko
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2025
Comment thread leaderelection/leader_election.go Outdated
Comment thread go.mod Outdated
Comment thread leaderelection/leader_election.go
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Sep 2, 2025

@DerekFrank can you please update to Kubernetes 1.34?

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Sep 9, 2025

/test pull-kubernetes-csi-csi-lib-utils
(just testing our CI, unrelated to this PR)

@DerekFrank
Copy link
Copy Markdown
Contributor Author

Waiting for kubernetes/kubernetes#134004

@DerekFrank DerekFrank force-pushed the leader-election-leases branch 2 times, most recently from ddb3660 to 4e3d0b5 Compare September 29, 2025 20:54
Comment thread leaderelection/leader_election.go Outdated
@DerekFrank DerekFrank force-pushed the leader-election-leases branch from 4e3d0b5 to 9a750b1 Compare October 1, 2025 16:19
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Oct 6, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DerekFrank, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 021c851 into kubernetes-csi:master Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leverage label functionality for leader election

5 participants