Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc to v1.59 #153

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Nov 9, 2023

Bump gRPC to the latest release.

v1.59 adds 30 minute idle timeout, i.e. a gRCP connections are closed after 30 minutes. Closed connection will cause CSI sidecars to exit. Therefore set idle timeout to 0 (never idle) in the library.

Fixes kubernetes-csi/external-provisioner#1099

Updated google.golang.org/grpc to v1.59.0. To keep existing behavior, gRPC connection idling is force disabled, i.e. a connection is *not* closed after 30 minutes of inactivity.

Bump gRPC to the latest release.

v1.59 adds 30 minute idle timeout, i.e. a gRCP connections are closed after
30 minutes. Therefore set idle timeout to 0 (never idle) in the library.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2023
@jsafrane
Copy link
Contributor Author

jsafrane commented Nov 9, 2023

@pohly can you please take a look?

@nixpanic
Copy link

nixpanic commented Nov 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 15dfc7a into kubernetes-csi:master Nov 9, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 13, 2023
jsafrane added a commit to jsafrane/external-provisioner that referenced this pull request Dec 11, 2023
There were several upstream OpenTelemetry bumps, this is just the last one.

Fixing CVE-2023-45142 and CVE-2023-47108.

Bumping github.com/kubernetes-csi/csi-lib-utils to disable CSI connection
idling, kubernetes-csi/csi-lib-utils#153
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/csi-external-provisioner that referenced this pull request Dec 12, 2023
There were several upstream OpenTelemetry bumps, this is just the last one.

Fixing CVE-2023-45142 and CVE-2023-47108.

Bumping github.com/kubernetes-csi/csi-lib-utils to disable CSI connection
idling, kubernetes-csi/csi-lib-utils#153
@msau42
Copy link
Collaborator

msau42 commented Dec 21, 2023

/cherry-pick release-0.15

k8s-ci-robot added a commit that referenced this pull request Dec 21, 2023
Manual cherry pick of #153: Bump google.golang.org/grpc to 1.59.0
k8s-ci-robot added a commit that referenced this pull request Dec 21, 2023
Manual cherry pick of #153: Bump google.golang.org/grpc to 1.59.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The provisioner exits after 30 minutes of idle.
4 participants