-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WithCustomRegistry for metrics #118
Conversation
Welcome @ayanamist! |
Hi @ayanamist. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I don't see any issues with this change. Can you clarify the release note though? Something like this-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Do you mean edit the content of PR or commit message? I have modified both. |
…n existing registry.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Is this compatible with k8s.io/component-base v0.26.0? |
Yes, it is compatible. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayanamist, ggriffiths, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
If users want to monitor workqueue metrics, they usually import
k8s.io/component-base/metrics/prometheus/workqueue
, which registers tok8s.io/component-base/metrics/legacyregistry
, however,csiMetricsManager
is using its own newly-created registry.Which issue(s) this PR fixes:
Make a new method
WithCustomRegistry
to let users pass in an exist registry.Special notes for your reviewer:
Does this PR introduce a user-facing change?: