Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connect function #11

Merged
merged 8 commits into from
Feb 7, 2019
Merged

Commits on Jan 18, 2019

  1. Add Connect function

    jsafrane committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    6ee8a5f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Update to dep 0.5

    jsafrane committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    e7386db View commit details
    Browse the repository at this point in the history
  2. Review updates

    jsafrane committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    635b0f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. connection: handle connection loss

    Some but not all CSI sidecar apps may want to cache information
    retrieved from a CSI driver. Those (and only) those apps needs a way
    to detect that the cached information became invalid due to a CSI
    driver restart and then react to that. The Connect function supports
    notifying the app via an optional callback which then can:
    - kill the app via os.Exit
    - invalidate the cached information and continue by reconnecting
    - prevent reconnecting and exit the application when gRPC method
      calls fail with status.Unavailable
    
    The default behavior is as before, i.e. the connection is getting
    restablished.
    pohly committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    8147e17 View commit details
    Browse the repository at this point in the history
  2. connection: add tests

    This verifies that both unix:/// and absolute paths work and that the
    timing behavior is as expected (wait for server, react promptly once
    it appears).
    pohly committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    fad9258 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Merge pull request #1 from pohly/connection-tests

    connection: add tests
    jsafrane authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    23d286e View commit details
    Browse the repository at this point in the history
  2. connection: replace glog with klog

    Kubernetes 1.13 already transitioned and the CSI sidecar containers
    are in the process of following that (for example, in
    kubernetes-csi/external-provisioner#219).
    pohly committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    e2d2c14 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from pohly/connection-logging

    connection: replace glog with klog
    jsafrane authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    155f487 View commit details
    Browse the repository at this point in the history