-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Connect function #11
Merged
Merged
Commits on Jan 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6ee8a5f - Browse repository at this point
Copy the full SHA 6ee8a5fView commit details
Commits on Jan 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e7386db - Browse repository at this point
Copy the full SHA e7386dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 635b0f9 - Browse repository at this point
Copy the full SHA 635b0f9View commit details
Commits on Jan 31, 2019
-
connection: handle connection loss
Some but not all CSI sidecar apps may want to cache information retrieved from a CSI driver. Those (and only) those apps needs a way to detect that the cached information became invalid due to a CSI driver restart and then react to that. The Connect function supports notifying the app via an optional callback which then can: - kill the app via os.Exit - invalidate the cached information and continue by reconnecting - prevent reconnecting and exit the application when gRPC method calls fail with status.Unavailable The default behavior is as before, i.e. the connection is getting restablished.
Configuration menu - View commit details
-
Copy full SHA for 8147e17 - Browse repository at this point
Copy the full SHA 8147e17View commit details -
This verifies that both unix:/// and absolute paths work and that the timing behavior is as expected (wait for server, react promptly once it appears).
Configuration menu - View commit details
-
Copy full SHA for fad9258 - Browse repository at this point
Copy the full SHA fad9258View commit details
Commits on Feb 4, 2019
-
Merge pull request #1 from pohly/connection-tests
connection: add tests
Configuration menu - View commit details
-
Copy full SHA for 23d286e - Browse repository at this point
Copy the full SHA 23d286eView commit details -
connection: replace glog with klog
Kubernetes 1.13 already transitioned and the CSI sidecar containers are in the process of following that (for example, in kubernetes-csi/external-provisioner#219).
Configuration menu - View commit details
-
Copy full SHA for e2d2c14 - Browse repository at this point
Copy the full SHA e2d2c14View commit details -
Merge pull request #2 from pohly/connection-logging
connection: replace glog with klog
Configuration menu - View commit details
-
Copy full SHA for 155f487 - Browse repository at this point
Copy the full SHA 155f487View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.