fix: consider only non-zero blocks for GetMetadataAllocated #579

iPraveenParihar · 2025-01-08T17:09:49Z

What type of PR is this?
/kind bug

What this PR does / why we need it:

The GetMetadataAllocated method previously returned all blocks,
including zero-filled ones (usually, unallocated/unused).
This commit updates the method to return only allocated (non-zero) blocks.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fixed: Considered only non-zero blocks for GetMetadataAllocated.

linux-foundation-easycla · 2025-01-08T17:09:53Z

The committers listed above are authorized under a signed CLA.

✅ login: iPraveenParihar / name: Praveen M (2d2a8d9)

k8s-ci-robot · 2025-01-08T17:09:58Z

Welcome @iPraveenParihar!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-01-08T17:09:59Z

Hi @iPraveenParihar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The `GetMetadataAllocated` method previously returned all blocks, including zero-filled ones (usually, unallocated/unused). This commit updates the method to return only allocated (non-zero) blocks. Signed-off-by: Praveen M <[email protected]>

nixpanic · 2025-01-10T13:05:51Z

pkg/hostpath/snapshotmetadata.go

-				blockIndex++
-				continue
+			// return only allocated blocks.
+			if blockChanged(zeroBlock, tBuffer[:targetReadBytes]) {


Does this work when a change wrote a whole lot of zero bytes over existing data to the volume?

I guess it should be fine, as cb.base == nil here.

This is for GetMetadataAllocated, where the backup application requires only the allocated data from the snapshot. During restoration, any uninitialized bytes will be filled with zeroes anyway.

Rakshith-R · 2025-01-20T15:45:16Z

/ok-to-test
/cc @carlbraganza @PrasadG193

Rakshith-R

Looks good to me

nixpanic · 2025-01-21T12:40:24Z

/lgtm

PrasadG193

/lgtm

xing-yang · 2025-01-21T18:41:11Z

Please add a release note.

xing-yang · 2025-01-21T18:41:43Z

/approve

/hold we can remove hold after a release note is added.

k8s-ci-robot · 2025-01-21T18:41:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iPraveenParihar, PrasadG193, Rakshith-R, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rakshith-R · 2025-01-22T15:39:37Z

we can remove hold after a release note is added.

Hey @xing-yang

The API implementation pr went was merged in december 2024
#569 (comment)

The last release was in september 2024 https://github.com/kubernetes-csi/csi-driver-host-path/releases/tag/v1.15.0

This pr would fix the implementation before it is present in a release.
Do we still need a release note in this case where the bug is never present in a previous release?

iPraveenParihar · 2025-01-24T05:22:41Z

added release note. PTAL @xing-yang 😃

iPraveenParihar · 2025-01-28T11:07:07Z

/cc @xing-yang

xing-yang · 2025-03-05T17:08:27Z

/hold cancel

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2025

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 8, 2025

k8s-ci-robot requested review from carlory and xing-yang January 8, 2025 17:09

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2025

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025

iPraveenParihar force-pushed the fix/allocated-non-zero-blocks branch from a7e249a to 2d2a8d9 Compare January 9, 2025 05:15

nixpanic reviewed Jan 10, 2025

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 15, 2025

k8s-ci-robot requested review from PrasadG193 and carlbraganza January 20, 2025 15:45

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2025

Rakshith-R approved these changes Jan 21, 2025

View reviewed changes

k8s-ci-robot assigned nixpanic Jan 21, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025

nixpanic removed their assignment Jan 21, 2025

PrasadG193 approved these changes Jan 21, 2025

View reviewed changes

k8s-ci-robot assigned PrasadG193 Jan 21, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025

k8s-ci-robot merged commit b0c4588 into kubernetes-csi:master Mar 6, 2025
10 checks passed

fix: consider only non-zero blocks for GetMetadataAllocated #579

fix: consider only non-zero blocks for GetMetadataAllocated #579

Conversation

iPraveenParihar commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 8, 2025

Uh oh!

k8s-ci-robot commented Jan 8, 2025

Uh oh!

nixpanic Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

nixpanic Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

iPraveenParihar Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

Rakshith-R commented Jan 20, 2025

Uh oh!

Rakshith-R left a comment

Choose a reason for hiding this comment

Uh oh!

nixpanic commented Jan 21, 2025

Uh oh!

PrasadG193 left a comment

Choose a reason for hiding this comment

Uh oh!

xing-yang commented Jan 21, 2025

Uh oh!

xing-yang commented Jan 21, 2025

Uh oh!

k8s-ci-robot commented Jan 21, 2025

Uh oh!

Rakshith-R commented Jan 22, 2025

Uh oh!

iPraveenParihar commented Jan 24, 2025

Uh oh!

iPraveenParihar commented Jan 28, 2025

Uh oh!

xing-yang commented Mar 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iPraveenParihar commented Jan 8, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jan 8, 2025 •

edited

Loading